From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add slurm-llnl. Date: Thu, 11 Feb 2016 09:28:01 +0100 Message-ID: <87ziv7tzvy.fsf@elephly.net> References: <56bb7530.v5bvas2QpzoMjKMl%pjotr.public12@thebird.nl> <20160210223330.6ad346c4@openmailbox.org> <20160211081733.GB8987@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTmbj-0005qx-DV for guix-devel@gnu.org; Thu, 11 Feb 2016 03:28:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTmbg-0003KI-7h for guix-devel@gnu.org; Thu, 11 Feb 2016 03:28:11 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:25958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTmbf-0003K3-Ts for guix-devel@gnu.org; Thu, 11 Feb 2016 03:28:08 -0500 In-reply-to: <20160211081733.GB8987@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel@gnu.org Pjotr Prins writes: > On Wed, Feb 10, 2016 at 10:33:30PM -0600, Eric Bavier wrote: >> On Wed, 10 Feb 2016 18:36:48 +0100 >> Pjotr Prins wrote: >> >> > * gnu/packages/parallel.scm (slurm-llnl): New variable. >> > --- >> > gnu/packages/parallel.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++--- >> > 1 file changed, 48 insertions(+), 3 deletions(-) >> [...] >> > + (license license:openssl))) >> >> There are several bits in the 'contribs' directory that seem to not be >> under free licenses. E.g. >> >> - contribs/cray/slurmconfgen_smw.py contains "Copyright 2015 Cray Inc. >> All Rights Reserved" >> >> - contribs/cray/slurmconfgen.py.in contains "Copyright 2013 Cray Inc. >> All Rights Reserved" >> >> - contribs/cray/libalps_test_programs.tar.gz contains a mixture of >> GPLv2, public domain, and binaries. >> >> - contribs/mic/mpirun-mic declares no license. >> >> - contribs/pmi2 is under a custom (copyleft?) license. >> >> - contribs/sgather declares no license. >> >> - contribs/sgi/netloc_to_topology.c contains "Copyright (C) 2014 >> Silicon Graphics International Corp. All rights reserved." >> >> - contribs/sjobexit/sjobexitmod.pl declares no license. >> >> I don't think we can claim any of these are covered under the same >> license as slurm, since the COPYING file explicitely says "Some tools >> in the "contribs" directory have other licenses." >> >> The contribs tools are not installed by default, but we do need to >> remove any non-free source from there with an origin snippet. >> >> Also, I found the DISCLAIMER file contains the "or (at your option) any >> later version." verbiage, so the slurm license itself is license:gpl2+ > > That was hard to find. Initially I had gpl2+ but they don't include the > license in the source so I defaulted to the license they include which > is openssl. But ja... > > I agree the rest is a mess but we aren't building contrib. Do you have > an example of a package that does this the right way? The best way is to remove the contrib directory in an origin snippet. We’re doing the same in the “shogun” package (in machine-learning.scm) as the upstream sources contain files that are not free software. The snippet in “shogun” is probably more complicated than what you’ll need for slurm-llnl; in many cases it’s enough to just do (begin (delete-file-recursively "contrib") #t) in a snippet. ~~ Ricardo