From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: add vte-ng Date: Thu, 31 Mar 2016 00:54:44 +0300 Message-ID: <87zitfws0r.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alO4g-0001Ef-GL for guix-devel@gnu.org; Wed, 30 Mar 2016 17:54:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alO4c-0000WY-FS for guix-devel@gnu.org; Wed, 30 Mar 2016 17:54:50 -0400 Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]:34896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alO4c-0000WU-84 for guix-devel@gnu.org; Wed, 30 Mar 2016 17:54:46 -0400 Received: by mail-lf0-x232.google.com with SMTP id k79so46048179lfb.2 for ; Wed, 30 Mar 2016 14:54:46 -0700 (PDT) In-Reply-To: (Mckinley Olsen's message of "Tue, 29 Mar 2016 17:52:18 -0600") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mckinley Olsen Cc: guix-devel@gnu.org Mckinley Olsen (2016-03-30 02:52 +0300) wrote: > Package vte-ng, which is needed by termite terminal (which I hope to > package) Hello, this is a great patch for the first package! I have only a couple of nitpicks and one real question. > From c06b9fe54d33d6c8624426771fbb52606f751f58 Mon Sep 17 00:00:00 2001 > From: McKinley Olsen > Date: Mon, 28 Mar 2016 15:03:06 -0600 > Subject: [PATCH] gnu: add vte-ng. Capital "Add" ----------^ > * gnu/packages/gnome.scm (vte-ng): added vte-ng package. We write it like this: * gnu/packages/gnome.scm (vte-ng): New variable. > --- > gnu/packages/gnome.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index eebb547..376ee74 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -1755,6 +1755,37 @@ gnome-terminal, but can also be used to embed a console/terminal in games, > editors, IDEs, etc.") > (license license:lgpl2.1+))) > > +(define-public vte-ng > + (package > + (inherit vte) > + (name "vte-ng") > + (version "0.42.4.a") > + (native-inputs > + `(("gtk-doc" ,gtk-doc) > + ("gperf" ,gperf) > + ("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ,@(package-native-inputs vte))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url (string-append "https://github.com/thestinger/" > + name > + ".git")) > + (commit version))) Why do you use git instead of the latest tagged source?: https://github.com/thestinger/vte-ng/archive/0.44.0.a.tar.gz > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "1w91lz30j5lrskp9ds5j3nn27m5mpdpn7nlcvf5y1w63mpmjg8k1")))) > + (arguments > + `(#:phases (modify-phases %standard-phases > + (add-after 'unpack 'bootstrap > + (lambda _ > + (setenv "NOCONFIGURE" "true") > + (zero? (system* "sh" "autogen.sh"))))))))) I think it also would be good to add its own synopsis/description to make it clear how it differs from "vte". -- Alex