From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Vong Subject: [PATCH 1/3] gnu: vlc: Add liba52 as inputs. Date: Sat, 10 Sep 2016 11:06:16 +0800 Message-ID: <87zingihcn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biYcb-0005RF-8Y for guix-devel@gnu.org; Fri, 09 Sep 2016 23:06:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biYcX-00085I-0A for guix-devel@gnu.org; Fri, 09 Sep 2016 23:06:24 -0400 Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]:35076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biYcW-00085C-OL for guix-devel@gnu.org; Fri, 09 Sep 2016 23:06:20 -0400 Received: by mail-pf0-x22c.google.com with SMTP id w87so34909287pfk.2 for ; Fri, 09 Sep 2016 20:06:20 -0700 (PDT) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=-=-= Content-Type: text/plain Hi, I split the patches into 3 parts following David's suggestion. The first patch removes the old FIXME by adding liba52 as inputs. The second patch adds some configure flags. The third patch adds many new inputs. Regarding Efraim's concern of closure size, the old closure size is 1459.3 MiB, the new closure size (without samba) is 1589.5 MiB and the new closure size (with samba) is 1681.8 MiB. Thanks, Alex --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-vlc-Add-liba52-as-inputs.patch Content-Transfer-Encoding: quoted-printable >From 6ed11031c136d7cff6fef60cc8e8fdb22dfb342e Mon Sep 17 00:00:00 2001 From: Alex Vong Date: Sat, 10 Sep 2016 00:06:26 +0800 Subject: [PATCH 1/3] gnu: vlc: Add liba52 as inputs. * gnu/packages/video.scm (vlc)[inputs]: Add liba52. [arguments]: Remove configure flag "--disable-a52". --- gnu/packages/video.scm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 864e691..858e007 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -6,7 +6,7 @@ ;;; Copyright =C2=A9 2015, 2016 Efraim Flashner ;;; Copyright =C2=A9 2015 Andy Patterson ;;; Copyright =C2=A9 2015 Ricardo Wurmus -;;; Copyright =C2=A9 2015 Alex Vong +;;; Copyright =C2=A9 2015, 2016 Alex Vong ;;; Copyright =C2=A9 2016 Alex Griffin ;;; Copyright =C2=A9 2016 Kei Kebreau ;;; Copyright =C2=A9 2016 Dmitry Nikolaev @@ -616,6 +616,7 @@ audio/video codec library.") ("fontconfig" ,fontconfig) ("freetype" ,freetype) ("gnutls" ,gnutls) + ("liba52" ,liba52) ("libcddb" ,libcddb) ("libgcrypt" ,libgcrypt) ("libkate" ,libkate) @@ -646,9 +647,7 @@ audio/video codec library.") ("xcb-util-keysyms" ,xcb-util-keysyms))) (arguments `(#:configure-flags - `("--disable-a52" ; FIXME: reenable once available - - ;; Gross workaround for . + `(;; Gross workaround for . ;; In our case, this led to a test failure: ;; test_libvlc_equalizer: libvlc/equalizer.c:122: test_equalize= r: Assertion `isnan(libvlc_audio_equalizer_get_amp_at_index (equalizer, u_b= ands))' failed. "ac_cv_c_fast_math=3Dno" --=20 2.10.0 --=-=-=--