From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: Re: [PATCH] gnu: Add git-review.
Date: Sat, 10 Sep 2016 23:25:40 +0200
Message-ID: <87zinfphuz.fsf@lassieur.org>
References: <20160908070630.18458-1-clement@lassieur.org>
	<439770f1-4691-45ac-348e-9e41bc126e0d@uq.edu.au>
	<20160908183217.GK12493@macbook42.flashner.co.il>
	<87oa3xfpmv.fsf@lassieur.org>
	<20160909150021.GD5507@macbook42.flashner.co.il>
	<87fup9f41n.fsf@lassieur.org>
	<20160910190536.GA6073@macbook42.flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1bipmU-0006Gg-RP
	for guix-devel@gnu.org; Sat, 10 Sep 2016 17:25:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1bipmQ-0003ja-KT
	for guix-devel@gnu.org; Sat, 10 Sep 2016 17:25:45 -0400
Received: from mail.lassieur.org ([83.152.10.219]:35882)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1bipmQ-0003jW-CY
	for guix-devel@gnu.org; Sat, 10 Sep 2016 17:25:42 -0400
In-reply-to: <20160910190536.GA6073@macbook42.flashner.co.il>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> writes:

>> It looks like ssh isn't hardcoded within git either. Is it worth doing
>> this for git-review then?
>
> This looks like you are using ssh for talking to the remote server, in
> which case it would exist outside of git-review. Or did I misunderstand
> it?

This error was a git error, when it tries to fetch a remote through ssh
in a container. It is kind of the same thing that happens with
git-review. Except that git-review is unusable without ssh. That's why
ssh has to be an input of git-review.

> It does seem that wrapping the program would be easier than trying to
> fing regexes that work to patching only certain instances of other
> programs.

I sent a patch that does the wrapping.