From: "Clément Lassieur" <clement@lassieur.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add git-review.
Date: Sat, 10 Sep 2016 23:25:40 +0200 [thread overview]
Message-ID: <87zinfphuz.fsf@lassieur.org> (raw)
In-Reply-To: <20160910190536.GA6073@macbook42.flashner.co.il>
Efraim Flashner <efraim@flashner.co.il> writes:
>> It looks like ssh isn't hardcoded within git either. Is it worth doing
>> this for git-review then?
>
> This looks like you are using ssh for talking to the remote server, in
> which case it would exist outside of git-review. Or did I misunderstand
> it?
This error was a git error, when it tries to fetch a remote through ssh
in a container. It is kind of the same thing that happens with
git-review. Except that git-review is unusable without ssh. That's why
ssh has to be an input of git-review.
> It does seem that wrapping the program would be easier than trying to
> fing regexes that work to patching only certain instances of other
> programs.
I sent a patch that does the wrapping.
next prev parent reply other threads:[~2016-09-10 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 7:06 [PATCH] gnu: Add git-review Clément Lassieur
2016-09-08 7:37 ` Vincent Legoll
2016-09-08 10:16 ` Efraim Flashner
2016-09-08 12:28 ` [PATCH] gnu: Add python-git-review Clément Lassieur
2016-09-08 17:45 ` Efraim Flashner
2016-09-08 12:28 ` [PATCH] gnu: Add git-review Ben Woodcroft
2016-09-08 17:58 ` Efraim Flashner
2016-09-09 16:24 ` Clément Lassieur
2016-09-09 20:27 ` Clément Lassieur
2016-09-08 18:32 ` Efraim Flashner
2016-09-09 8:23 ` Clément Lassieur
2016-09-09 15:00 ` Efraim Flashner
2016-09-09 16:09 ` Clément Lassieur
2016-09-10 19:05 ` Efraim Flashner
2016-09-10 21:13 ` [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found Clément Lassieur
2016-09-11 7:05 ` Efraim Flashner
2016-09-10 21:25 ` Clément Lassieur [this message]
2016-09-09 18:49 ` [PATCH] gnu: Add git-review Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zinfphuz.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.