From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 1/2] gnu: gnunet: Add inputs. Date: Mon, 19 Sep 2016 14:30:15 +0000 Message-ID: <87zin42c94.fsf@we.make.ritual.n0.is> References: <20160916134921.17987-1-ng0@we.make.ritual.n0.is> <8737kwm2y5.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blzab-0001oh-5o for guix-devel@gnu.org; Mon, 19 Sep 2016 10:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blzaW-00045l-4q for guix-devel@gnu.org; Mon, 19 Sep 2016 10:30:33 -0400 Received: from aibo.runbox.com ([91.220.196.211]:57032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blzaV-000446-TV for guix-devel@gnu.org; Mon, 19 Sep 2016 10:30:28 -0400 In-Reply-To: <8737kwm2y5.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: > ng0 writes: > >> * gnu/packages/gnunet.scm (gnunet)[inputs]: Add inputs >> zlib, perl, jansson, ncurses, nss, gmp, bluez, glib, libogg. >> (gnunet)[native-inputs]: Move python-2 from here ... >> to (gnunet)[inputs]. > > Have you checked that the resulting build artifacts retain references to > all these new inputs? With the assumption that currently our gnunet usage is limited because we ship out 0.10.1 which is no longer compatible to HEAD but a release will happen soon, I don't know if all of this is featured in the very old version 0.10.1, but iirc there weren't many changes in dependencies, so they should be used. Could be that I need to pass some switches. I'll send an updated patch later and document which dependency is needed for which part. > Is adding “bluez” and “libogg” really needed? They seem a little > unusual for networking software. It is not just networking software. It's been to long since I found out all these dependencies, I just decided to add them to guix master now. Bluez is for bluetooth support of whatever feature (look it up in either documentation or the Makefile), libogg is needed for audio playback I think. I could be wrong about this one. You know, the longer you work on something the more you find and without comments it all gets obscure. But I really think libogg in addition to libopus is for something audio related. If you think comments are needed because someone in the future could decide to cut down the "bloat", I can comment all the dependencies with which part of GNUnet needs them. https://gnunet.org/bugs/view.php?id=4618 I could also add tex, but I will add a variant of gnunet later which adds tex as a dependency. > ~~ Ricardo > > -- ng0