[core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[Leo Famulari]

On core-updates, from 6671ce93 (gnu: ath9k-htc-firmware: Update binutils
patch for binutils 2.27), I can't build gtk+@3.20 because the daemon
finds a cycle in the references:

------
starting phase `validate-runpath'
validating RUNPATH of 17 binaries in "/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/lib"...
validating RUNPATH of 10 binaries in "/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin"...
phase `validate-runpath' succeeded after 0.2 seconds
starting phase `validate-documentation-location'
phase `validate-documentation-location' succeeded after 0.0 seconds
starting phase `delete-info-dir-file'
phase `delete-info-dir-file' succeeded after 0.0 seconds
starting phase `patch-dot-desktop-files'
adjusting 3 '.desktop' files in "/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications"
phase `patch-dot-desktop-files' succeeded after 0.0 seconds
starting phase `compress-documentation'
compressing documentation in '/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/man' with "gzip" and flags ("--best" "--no-name")
phase `compress-documentation' succeeded after 0.0 seconds
cycle detected in the references of `/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin'
cannot build derivation `/gnu/store/8mpv03c557g56q1vmym53pm0apxj6p30-gtk-icon-themes.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/wd7lz1x2jqfj1z46872fc2lh5ga13gzx-profile.drv': 1 dependencies couldn't be built
killing process 31697
cannot build derivation `/gnu/store/0id6isvf9ljkgx7kf58w5mnhwh805apl-system.drv': 1 dependencies couldn't be built
guix system: error: build failed: build of `/gnu/store/0id6isvf9ljkgx7kf58w5mnhwh805apl-system.drv' failed
------

And here are the references. I didn't check if there were any in the doc
output since I didn't see it in the build log.

------
$ grep -r dsnckvh133ndivnnbspg2yziqmlg1c4p /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-query-immodules-3.0 matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo-application matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-builder-tool matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-query-settings matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-icon-browser matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-update-icon-cache matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-widget-factory matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-launch matches
Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-encode-symbolic-svg matches
$ grep -r 28mzpkx23h4cnrhc2ijkp46hiiz06na0 /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9
/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-demo.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo
/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-widget-factory.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-widget-factory
/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-icon-browser.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-icon-browser
------

It works if I remove the 'bin' output from gtk+@3.

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[Leo Famulari]

On Thu, Oct 13, 2016 at 01:24:47AM -0400, Leo Famulari wrote:
> It works if I remove the 'bin' output from gtk+@3.

I think I was mistaken. If I don't use a separate 'bin' output, I can
build the package, but I still get an error with `guix system build`:

guix system: error: reference to invalid output 'bin' of derivation '/gnu/store/hb07mzbrn4nqwdlimjbbbdkm2nnvbsvz-gtk+-3.20.9.drv'

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[宋文武]

Leo Famulari <leo@famulari.name> writes:

> On core-updates, from 6671ce93 (gnu: ath9k-htc-firmware: Update binutils
> patch for binutils 2.27), I can't build gtk+@3.20 because the daemon
> finds a cycle in the references:
>
> ------
> starting phase `validate-runpath'
> validating RUNPATH of 17 binaries in "/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/lib"...
> validating RUNPATH of 10 binaries in "/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin"...
> phase `validate-runpath' succeeded after 0.2 seconds
> starting phase `validate-documentation-location'
> phase `validate-documentation-location' succeeded after 0.0 seconds
> starting phase `delete-info-dir-file'
> phase `delete-info-dir-file' succeeded after 0.0 seconds
> starting phase `patch-dot-desktop-files'
> adjusting 3 '.desktop' files in "/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications"
> phase `patch-dot-desktop-files' succeeded after 0.0 seconds
> starting phase `compress-documentation'
> compressing documentation in '/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/man' with "gzip" and flags ("--best" "--no-name")
> phase `compress-documentation' succeeded after 0.0 seconds
> cycle detected in the references of `/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin'
> cannot build derivation `/gnu/store/8mpv03c557g56q1vmym53pm0apxj6p30-gtk-icon-themes.drv': 1 dependencies couldn't be built
> cannot build derivation `/gnu/store/wd7lz1x2jqfj1z46872fc2lh5ga13gzx-profile.drv': 1 dependencies couldn't be built
> killing process 31697
> cannot build derivation `/gnu/store/0id6isvf9ljkgx7kf58w5mnhwh805apl-system.drv': 1 dependencies couldn't be built
> guix system: error: build failed: build of `/gnu/store/0id6isvf9ljkgx7kf58w5mnhwh805apl-system.drv' failed
> ------
>
> And here are the references. I didn't check if there were any in the doc
> output since I didn't see it in the build log.
>
> ------
> $ grep -r dsnckvh133ndivnnbspg2yziqmlg1c4p /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-query-immodules-3.0 matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo-application matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-builder-tool matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-query-settings matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-icon-browser matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-update-icon-cache matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-widget-factory matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-launch matches
> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-encode-symbolic-svg matches
> $ grep -r 28mzpkx23h4cnrhc2ijkp46hiiz06na0 /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9
> /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-demo.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo
> /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-widget-factory.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-widget-factory
> /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-icon-browser.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-icon-browser
> ------
>
> It works if I remove the 'bin' output from gtk+@3.

Oh, I added the 'bin' output to gtk+ without moving its desktop files.
And now the 'patch-dot-desktop-files' phase in gnu-build-system gives
absolute paths to desktop files, so it fails with cycle references.

Move all the 3 desktop files into 'bin' output should work.  (I could
patch that next day, but won't be able to test it due to slow
substitute/download/build speed though.)

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Oct 13, 2016 at 01:24:47AM -0400, Leo Famulari wrote:
>> It works if I remove the 'bin' output from gtk+@3.
>
> I think I was mistaken. If I don't use a separate 'bin' output, I can
> build the package, but I still get an error with `guix system build`:
>
> guix system: error: reference to invalid output 'bin' of derivation '/gnu/store/hb07mzbrn4nqwdlimjbbbdkm2nnvbsvz-gtk+-3.20.9.drv'

This is expected: it means that some packages or gexps refer to the
“bin” output of GTK+, which no longer exists.  For instance, the
‘gtk-icon-themes’ procedure in (guix profile) does exactly that.

If we remove “bin”, these will have to be updated.

Thanks,
Ludo’.

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[Ludovic Courtès]

iyzsong@member.fsf.org (宋文武) skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On core-updates, from 6671ce93 (gnu: ath9k-htc-firmware: Update binutils
>> patch for binutils 2.27), I can't build gtk+@3.20 because the daemon
>> finds a cycle in the references:
>>
>> ------
>> starting phase `validate-runpath'
>> validating RUNPATH of 17 binaries in "/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/lib"...
>> validating RUNPATH of 10 binaries in "/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin"...
>> phase `validate-runpath' succeeded after 0.2 seconds
>> starting phase `validate-documentation-location'
>> phase `validate-documentation-location' succeeded after 0.0 seconds
>> starting phase `delete-info-dir-file'
>> phase `delete-info-dir-file' succeeded after 0.0 seconds
>> starting phase `patch-dot-desktop-files'
>> adjusting 3 '.desktop' files in "/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications"
>> phase `patch-dot-desktop-files' succeeded after 0.0 seconds
>> starting phase `compress-documentation'
>> compressing documentation in '/gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/man' with "gzip" and flags ("--best" "--no-name")
>> phase `compress-documentation' succeeded after 0.0 seconds
>> cycle detected in the references of `/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin'
>> cannot build derivation `/gnu/store/8mpv03c557g56q1vmym53pm0apxj6p30-gtk-icon-themes.drv': 1 dependencies couldn't be built
>> cannot build derivation `/gnu/store/wd7lz1x2jqfj1z46872fc2lh5ga13gzx-profile.drv': 1 dependencies couldn't be built
>> killing process 31697
>> cannot build derivation `/gnu/store/0id6isvf9ljkgx7kf58w5mnhwh805apl-system.drv': 1 dependencies couldn't be built
>> guix system: error: build failed: build of `/gnu/store/0id6isvf9ljkgx7kf58w5mnhwh805apl-system.drv' failed
>> ------
>>
>> And here are the references. I didn't check if there were any in the doc
>> output since I didn't see it in the build log.
>>
>> ------
>> $ grep -r dsnckvh133ndivnnbspg2yziqmlg1c4p /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-query-immodules-3.0 matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo-application matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-builder-tool matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-query-settings matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-icon-browser matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-update-icon-cache matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-widget-factory matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-launch matches
>> Binary file /gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk-encode-symbolic-svg matches
>> $ grep -r 28mzpkx23h4cnrhc2ijkp46hiiz06na0 /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9
>> /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-demo.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-demo
>> /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-widget-factory.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-widget-factory
>> /gnu/store/dsnckvh133ndivnnbspg2yziqmlg1c4p-gtk+-3.20.9/share/applications/gtk3-icon-browser.desktop:Exec=/gnu/store/28mzpkx23h4cnrhc2ijkp46hiiz06na0-gtk+-3.20.9-bin/bin/gtk3-icon-browser
>> ------
>>
>> It works if I remove the 'bin' output from gtk+@3.
>
> Oh, I added the 'bin' output to gtk+ without moving its desktop files.
> And now the 'patch-dot-desktop-files' phase in gnu-build-system gives
> absolute paths to desktop files, so it fails with cycle references.

Good catch!

> Move all the 3 desktop files into 'bin' output should work.  (I could
> patch that next day, but won't be able to test it due to slow
> substitute/download/build speed though.)

That should work.  You can post the patch here so we can test, if you
want.

Thanks in advance.  :-)

Ludo’.

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[宋文武]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]


>> [...]
>> Move all the 3 desktop files into 'bin' output should work.  (I could
>> patch that next day, but won't be able to test it due to slow
>> substitute/download/build speed though.)
>
> That should work.  You can post the patch here so we can test, if you
> want.

Sure, here is it:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gtk-Move-desktop-files-into-bin-output.patch --]
[-- Type: text/x-patch, Size: 1384 bytes --]

From 4746292d8a672dbc3ea8d058baf6239974d92103 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
Date: Fri, 14 Oct 2016 22:57:53 +0800
Subject: [PATCH] gnu: gtk+: Move desktop files into "bin" output.

* gnu/packages/gtk.scm (gtk+)[arguments]: Add 'move-desktop-files' phase.
---
 gnu/packages/gtk.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 183989b..0de1409 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -685,7 +685,16 @@ application suites.")
             (substitute* "testsuite/Makefile.in"
               (("SUBDIRS = gdk gtk a11y css reftests")
                "SUBDIRS = gdk"))
-            #t)))))
+            #t))
+        (add-after 'install 'move-desktop-files
+          ;; Move desktop files into 'bin' to avoid cycle references.
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let ((out (assoc-ref outputs "out"))
+                  (bin (assoc-ref outputs "bin")))
+              (mkdir-p (string-append bin "/share"))
+              (rename-file (string-append out "/share/applications")
+                           (string-append bin "/share/applications"))
+              #t))))))
    (native-search-paths
     (list (search-path-specification
            (variable "GUIX_GTK3_PATH")
-- 
2.10.0


[-- Attachment #3: Type: text/plain, Size: 25 bytes --]


Please test it, Thanks!

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

On Fri, Oct 14, 2016 at 11:03:59PM +0800, ????????? wrote:
     
     >> [...]
     >> Move all the 3 desktop files into 'bin' output should work.  (I could
     >> patch that next day, but won't be able to test it due to slow
     >> substitute/download/build speed though.)
     >
     > That should work.  You can post the patch here so we can test, if you
     > want.
     
     Sure, here is it:

Where?
     


-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[Leo Famulari]

On Fri, Oct 14, 2016 at 11:03:59PM +0800, 宋文武 wrote:
> 
> >> [...]
> >> Move all the 3 desktop files into 'bin' output should work.  (I could
> >> patch that next day, but won't be able to test it due to slow
> >> substitute/download/build speed though.)
> >
> > That should work.  You can post the patch here so we can test, if you
> > want.
> 
> Sure, here is it:
> 

> From 4746292d8a672dbc3ea8d058baf6239974d92103 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
> Date: Fri, 14 Oct 2016 22:57:53 +0800
> Subject: [PATCH] gnu: gtk+: Move desktop files into "bin" output.
> 
> * gnu/packages/gtk.scm (gtk+)[arguments]: Add 'move-desktop-files' phase.

Thanks, this works for me! With this patch, `guix system build` passed
the point where it previously failed.

Re: [core-updates]: cycle detected in the references of ...gtk+-3.20.9-bin

[宋文武]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Oct 14, 2016 at 11:03:59PM +0800, 宋文武 wrote:
>> 
>> >> [...]
>> >> Move all the 3 desktop files into 'bin' output should work.  (I could
>> >> patch that next day, but won't be able to test it due to slow
>> >> substitute/download/build speed though.)
>> >
>> > That should work.  You can post the patch here so we can test, if you
>> > want.
>> 
>> Sure, here is it:
>> 
>
>> From 4746292d8a672dbc3ea8d058baf6239974d92103 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>> Date: Fri, 14 Oct 2016 22:57:53 +0800
>> Subject: [PATCH] gnu: gtk+: Move desktop files into "bin" output.
>> 
>> * gnu/packages/gtk.scm (gtk+)[arguments]: Add 'move-desktop-files' phase.
>
> Thanks, this works for me! With this patch, `guix system build` passed
> the point where it previously failed.

Pushed, thanks!