From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH 14/16] gnu: Add python-jupyter-console.
Date: Tue, 01 Nov 2016 19:15:00 +0100
Message-ID: <87ziljnk2j.fsf@gnu.org>
References: <20161101122046.751-1-ricardo.wurmus@mdc-berlin.de>
	<20161101122046.751-15-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59173)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1dZA-0002BB-Sv
	for guix-devel@gnu.org; Tue, 01 Nov 2016 14:13:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1dZ6-0003hg-TH
	for guix-devel@gnu.org; Tue, 01 Nov 2016 14:13:44 -0400
In-reply-to: <20161101122046.751-15-ricardo.wurmus@mdc-berlin.de>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org


Ricardo Wurmus writes:

> * gnu/packages/python.scm (python-jupyter-console,
> python2-jupyter-console): New variable.
> ---
>  gnu/packages/python.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 50a0edd..519b93d 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6914,6 +6914,35 @@ in the data.")
>  (define-public python2-ipywidgets
>    (package-with-python2 python-ipywidgets))
>  
> +(define-public python-jupyter-console
> +  (package
> +    (name "python-jupyter-console")
> +    (version "5.0.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "jupyter_console" version))
> +       (sha256
> +        (base32
> +         "04acmkwsi99rcg3vb54c6n492zv35s92h2ahabc0w6wj976cipvx"))))
> +    (build-system python-build-system)
> +    ;; FIXME: it's not clear how to run the tests.
> +    (arguments `(#:tests? #f))
> +    (propagated-inputs
> +     `(("python-ipykernel" ,python-ipykernel)
> +       ("python-ipython" ,python-ipython)
> +       ("python-jupyter-client" ,python-jupyter-client)
> +       ("python-prompt-toolkit" ,python-prompt-toolkit)
> +       ("python-pygments" ,python-pygments)
> +       ("python-setuptools" ,python-setuptools)))
> +    (home-page "https://jupyter.org")
> +    (synopsis "Jupyter terminal console")
> +    (description "Jupyter terminal console")

How about:
"This package provides a terminal window in the browser to directly
access the machine Jupyter is running on."

> +    (license license:bsd-3)))
> +
> +(define-public python2-jupyter-console
> +  (package-with-python2 python-jupyter-console))
> +
>  (define-public python-chardet
>    (package
>      (name "python-chardet")

Otherwise LGTM.

Kind regards,
Roel Janssen