From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 3/6] gnu: Add python-furl. Date: Sat, 05 Nov 2016 15:50:01 +0000 Message-ID: <87zile53km.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161105112706.12089-1-dannym@scratchpost.org> <20161105112706.12089-4-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c33ER-0002MB-1v for guix-devel@gnu.org; Sat, 05 Nov 2016 11:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c33EN-00044e-W5 for guix-devel@gnu.org; Sat, 05 Nov 2016 11:50:11 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44192) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c33EN-00044H-S5 for guix-devel@gnu.org; Sat, 05 Nov 2016 11:50:07 -0400 In-Reply-To: <20161105112706.12089-4-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: > * gnu/packages/python.scm (python-furl, python2-furl): New variables. > > --- > gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 49c09fc..3eb33de 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -3898,6 +3898,39 @@ dictionary that retains the order of insertions an= d deletions.") > `(("python2-setuptools" ,python2-setuptools) > ,@(package-native-inputs base)))))) >=20=20 > +(define-public python-furl > + (package > + (name "python-furl") > + (version "0.5.6") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "furl" version)) > + (sha256 > + (base32 > + "0lzpfpm686hvz3sr1mcrnd1b3lgmnw8v59gb43wfi98r3b671pqc")))) > + (build-system python-build-system) > + (propagated-inputs > + `(("python-six" ,python-six) > + ("python-orderedmultidict" ,python-orderedmultidict))) > + (native-inputs > + `(("python-pycodestyle" ,python-pycodestyle))) > + (home-page "https://github.com/gruns/furl") > + (synopsis "URL manipulation in Python") > + (description "Python's standard urllib and urlparse modules provide a > +number of URL manipulation functions, but using these functions to perfo= rm > +common URL manipulations proves tedious. Furl makes manipulating URLs ea= sy.") I'm not sure about the description. Why is urllib and urlparse tedious, and what makes this package better? Perhaps it can be written as "Furl is an easier-to-use alternative to the @code{urllib} and @code{urlparse} modules for manipulating URLs.". Or something like that. Otherwise LGTM. > + (license license:unlicense) > + (properties `((python2-variant . ,(delay python2-furl)))))) > + > +(define-public python2-furl > + (let ((base (package-with-python2 (strip-python2-variant > + python-furl)))) > + (package (inherit base) > + (native-inputs > + `(("python2-setuptools" ,python2-setuptools) > + ,@(package-native-inputs base)))))) > + > (define-public python-sqlalchemy-utils > (package > (name "python-sqlalchemy-utils") --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYHf+pAAoJEKKgbfKjOlT6T4YH/3S2cIP37IJEGof8FG5PlmQP ei8TXjTvi6IZ3vRWVjvXXYwuU/IwPeDdih+SFs8Ysp7mJLDONE+gepNaSw/oXPVh dHYKkjGS+dpn9DbfUWFVM5KYH2bt8aDqLbWWlWUaiyNEZH14sBdOJtIApdoQxyEG 1P3d7fvXVusTIC2avkWzriuMBG+jYzlKtGn5EyQwpeudaNQ93ES7PSPpmX8S+e4e b/yNM9wdzgr3LnsSa8vyeClALptHayAruOcROqjXqGDPJVlMBAWotjrIlY+eX0/7 8nEXv4EDuDHTVGHBm2iYPrhfz4hGFFIOVOj4VTIq4/IhfWmjUYzPOQYPPYvpT6Q= =wWZY -----END PGP SIGNATURE----- --=-=-=--