Re: [PATCH 3/6] gnu: Add python-furl.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-furl, python2-furl): New variables.
>
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 49c09fc..3eb33de 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3898,6 +3898,39 @@ dictionary that retains the order of insertions and deletions.")
>         `(("python2-setuptools" ,python2-setuptools)
>           ,@(package-native-inputs base))))))
>  
> +(define-public python-furl
> +  (package
> +    (name "python-furl")
> +    (version "0.5.6")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "furl" version))
> +        (sha256
> +          (base32
> +            "0lzpfpm686hvz3sr1mcrnd1b3lgmnw8v59gb43wfi98r3b671pqc"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-orderedmultidict" ,python-orderedmultidict)))
> +    (native-inputs
> +     `(("python-pycodestyle" ,python-pycodestyle)))
> +    (home-page "https://github.com/gruns/furl")
> +    (synopsis "URL manipulation in Python")
> +    (description "Python's standard urllib and urlparse modules provide a
> +number of URL manipulation functions, but using these functions to perform
> +common URL manipulations proves tedious. Furl makes manipulating URLs easy.")

I'm not sure about the description. Why is urllib and urlparse tedious,
and what makes this package better? Perhaps it can be written as "Furl
is an easier-to-use alternative to the @code{urllib} and @code{urlparse}
modules for manipulating URLs.". Or something like that.

Otherwise LGTM.

> +    (license license:unlicense)
> +    (properties `((python2-variant . ,(delay python2-furl))))))
> +
> +(define-public python2-furl
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-furl))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools)
> +         ,@(package-native-inputs base))))))
> +
>  (define-public python-sqlalchemy-utils
>    (package
>      (name "python-sqlalchemy-utils")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]