From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH 2/2] services: network-manager: Use record for configuration. Date: Thu, 19 Jan 2017 19:44:24 +0800 Message-ID: <87ziinb7fr.fsf@member.fsf.org> References: <20170119065539.988-1-mail@cbaines.net> <20170119065539.988-2-mail@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUB9N-0002nu-1K for guix-devel@gnu.org; Thu, 19 Jan 2017 06:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUB9K-0006dG-01 for guix-devel@gnu.org; Thu, 19 Jan 2017 06:45:05 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:35323) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cUB9J-0006cK-QI for guix-devel@gnu.org; Thu, 19 Jan 2017 06:45:01 -0500 In-Reply-To: <20170119065539.988-2-mail@cbaines.net> (Christopher Baines's message of "Thu, 19 Jan 2017 06:55:39 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org Christopher Baines writes: > * gnu/services/network-manager.scm (): New > record type. > (network-manager-shpeherd-service): Change to use the > network-manager-configuration record, rather than a package. Generate a > simple configuration file from the network-manager-configuration record. > (network-manager-service-type): Update extensions to take the > network-manager-configuration rather than a package. > --- > gnu/services/networking.scm | 77 +++++++++++++++++++++++++++++---------------- > 1 file changed, 50 insertions(+), 27 deletions(-) Thanks, could you mention the remove of 'network-manager-service' in the changelog and update the 'Network Manager' section of manual?