From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: ldc: Update to 1.1.0.
Date: Thu, 09 Feb 2017 17:38:31 +0100
Message-ID: <87zihvxqt4.fsf@gnu.org>
References: <20170201095132.9579-1-dannym@scratchpost.org>
	<20170201095132.9579-3-dannym@scratchpost.org>
	<20170203164521.GA2411@macbook42.flashner.co.il>
	<20170203203704.14c4051e@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cbrjy-0000c5-40
	for guix-devel@gnu.org; Thu, 09 Feb 2017 11:38:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cbrju-0008V2-6J
	for guix-devel@gnu.org; Thu, 09 Feb 2017 11:38:38 -0500
In-Reply-To: <20170203203704.14c4051e@scratchpost.org> (Danny Milosavljevic's
	message of "Fri, 3 Feb 2017 20:37:04 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Fri, 3 Feb 2017 18:45:22 +0200
> Efraim Flashner <efraim@flashner.co.il> wrote:
>
>> On Wed, Feb 01, 2017 at 10:51:32AM +0100, Danny Milosavljevic wrote:
>> >               ;; files left with the --keep-failed flag to guix build.
>> >               (patches (search-patches "ldc-1.1.0-disable-dmd-tests.pa=
tch")))))))))
>> >=20=20
>> > -(define-public ldc-beta ldc-1.1.0-beta6)
>> > -
>
>> Without having built it to test it out, I would replace this part with
>> either having it superceded by ldc-1.1.0, or have ldc-beta point to
>> ldc-1.1.0, so no one who relies on it finds it broken.
>
> Ehhh. The variable "ldc-beta" would have existed for 5 days and was in no=
 Guix release - not sure anyone saw it.
>
> But we can do the latter so that people could rely on ldc-beta being the =
newest non-release ldc (if we ever packaged another ldc beta release or eve=
n git commit), kinda like guix-devel (corresponding to ldc-beta) vs. guix (=
corresponding to ldc). Sure.

I agree.  Both patches look good to me, I think you can go ahead!

Thank you,
Ludo=E2=80=99.