From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7f7D-00027M-Sc
	for guix-patches@gnu.org; Mon, 08 May 2017 05:38:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7f7C-00036Z-TG
	for guix-patches@gnu.org; Mon, 08 May 2017 05:38:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34748)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7f7C-000369-PU
	for guix-patches@gnu.org; Mon, 08 May 2017 05:38:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7f7C-0005eH-Gy
	for guix-patches@gnu.org; Mon, 08 May 2017 05:38:02 -0400
Subject: bug#26339: [PATCH v2 01/12] system: Pass <bootloader-parameter> to
	grub.
Resent-Message-ID: <handler.26339.B26339.149423627921705@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170417090148.13791-1-m.othacehe@gmail.com>
	<20170417090148.13791-2-m.othacehe@gmail.com>
Date: Mon, 08 May 2017 11:37:41 +0200
In-Reply-To: <20170417090148.13791-2-m.othacehe@gmail.com> (Mathieu Othacehe's
	message of "Mon, 17 Apr 2017 11:01:37 +0200")
Message-ID: <87zienofiy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

Hi,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/system.scm (operating-system-grub.cfg): Pass <bootloader-parameter>.
> * gnu/system/grub.scm (boot-parameters->menu-entry): New variable.
>   (grub-configuration-file): Use boot-parameters->menu-entry.

This patch as applied in 2e58e05bb6 causes a circular dependency between
(gnu system) and (gnu system grub), which is not OK given that they rely
on macros (actually record accessors) coming from each others.  This
causes evaluation to fail (see
<https://hydra.gnu.org/jobset/gnu/master#tabs-errors>):

--8<---------------cut here---------------start------------->8---
In gnu/system/grub.scm:
 272: 1 [boot-parameters->menu-entry #]
In unknown file:
   ?: 0 [# #]

ERROR: In procedure #<syntax-transformer boot-parameters-label>:
ERROR: Wrong type to apply: #<syntax-transformer boot-parameters-label>
--8<---------------cut here---------------end--------------->8---

Since the goal of this patch set was to support multiple bootloaders,
the right fix would be for (gnu system) to not use (gnu system grub).
Instead there should probably be a (gnu system bootloaders) module
providing a bootloader abstraction.

However, I=E2=80=99m not sure about the details of all this.  If we cannot =
fix
it today, we=E2=80=99ll have to revert this change, though I=E2=80=99m unsu=
re exactly
how many commits depend on it.

Thoughts?

Ludo=E2=80=99.