[bug#27682] [PATCH 2/2] gnu: Add lxc.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

宋文武 <iyzsong@member.fsf.org> writes:

> * gnu/packages/virtualization.scm (lxc): New package.

Thanks!

[...]

> +    (arguments
> +     '(#:configure-flags
> +       '("--sysconfdir=/etc"
> +         "--localstatedir=/var")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out         (assoc-ref outputs "out"))
> +                    (bashcompdir (string-append out "/etc/bash_completion.d")))
> +               (zero? (system*
> +                       "make" "install"
> +                       (string-append "bashcompdir=" bashcompdir)
> +                       ;; Thoses files will be handled by system services.
> +                       "LXCPATH=/tmp/var/lib/lxc"
> +                       "localstatedir=/tmp/var"
> +                       "sysconfdir=/tmp/etc"
> +                       "sysconfigdir=/tmp/etc/default"))))))))

If these are not important, why not set them to $out/etc, $out/var and
so on? /tmp seems like a dangerous default to me, since any unprivileged
user can populate these directories.

LGTM apart from that.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]