From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eALfm-00064a-ID for guix-patches@gnu.org; Thu, 02 Nov 2017 16:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eALfi-0000VP-MC for guix-patches@gnu.org; Thu, 02 Nov 2017 16:01:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eALfi-0000UQ-BM for guix-patches@gnu.org; Thu, 02 Nov 2017 16:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eALfh-0006Qr-Rd for guix-patches@gnu.org; Thu, 02 Nov 2017 16:01:01 -0400 Subject: [bug#29099] [PATCH] gnu: Add kodi-cli. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87mv45vy7l.fsf@gmail.com> References: <8760au8pfk.fsf@gmail.com> <87a8054rd9.fsf@fastmail.com> <87mv45vy7l.fsf@gmail.com> Date: Thu, 02 Nov 2017 21:00:14 +0100 Message-ID: <87zi8430z5.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 29099@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oleg Pykhalov writes: > Hello Marius, > > Thank you for review! > > Marius Bakke writes: > >>> +(define-public kodi-cli >>> + (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add supp= ort for >>> + (revision "1")) ; `$HOME/.= kodirc'. >>> + (package >>> + (name "kodi-cli") >>> + (version (string-append "1.1-" revision "." (string-take commit = 7))) >>> + (source (origin >>> + (method git-fetch) >>> + (uri (git-reference (url "https://github.com/nawar/kod= i-cli") >>> + (commit commit))) >>> + (sha256 >>> + (base32 >>> + "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5= p")) >>> + (file-name (string-append name "-" version "-checkout"= )))) >>> + (build-system trivial-build-system) >>> + (inputs `(("bash" ,bash))) >>> + (propagated-inputs `(("curl" ,curl))) >> >> There is only one reference to `curl` in the script, can you try to >> substitute it with the absolute path and make it a regular input? It's >> good to avoid propagation when we can. > > Done. I also added input mps-youtube and did the same. Excellent. >>> +@item Interactive and noninteractive volume control. >>> +@item Interactive navigation. >>> +@item Send text. >> >> What does this mean? Arbitrary commands, or text notifications? > > From my experience this allows you do the following: > > 1. Open Videos. > 2. Add videos=E2=80=A6 > 3. Select . > 4. Enter path by sending a command via 'kodi-cli -t PATH'. > > Maybe call this item of the feature list as > =E2=80=9CSend text to the Kodi keyboard=E2=80=9D? "Send text to the Kodi keyboard" is much better, thanks! > New patch is attached. [...] > + (arguments > + `(#:modules ((guix build utils)) > + #:builder > + (begin > + (use-modules (guix build utils)) > + (copy-recursively (assoc-ref %build-inputs "source") ".") > + (substitute* "kodi-cli" > + (("/bin/bash") (string-append (assoc-ref %build-inputs "bas= h") > + "/bin/bash")) > + (("output=3D\\$\\((curl)" all curl) > + (string-append "output=3D$(" > + (assoc-ref %build-inputs "curl") > + "/bin/" curl)) > + (("play_youtube `(mpsyt)" all mpsyt) > + (string-append "play_youtube `" > + (assoc-ref %build-inputs "mps-youtube") > + "/bin/" mpsyt))) FYI, you could also use (which "curl") etc from (guix build utils) here, but I usually prefer this form. [...] > +@itemize > +@item Play, pause, stop the current playing item. > +@item Skip forward or backward in the current playing item. These should be "currently playing". > +@item Play or queue to the current list YouTube videos. "... current list of YouTube videos." (note the "of") LGTM otherwise. Don't forget to add a copyright line for yourself. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAln7eU8ACgkQoqBt8qM6 VPquawf+KndR6f5zs5LHkM3FzM8W+ero3tgPwAiWZeza+c3os9YZs9NrStOatchE XT6OViWp+rRKQt7viU+qqdBnV5lmREXbFXg+h8Wxzh9MCwpn++Gn80HqukYQSAJk k7Ay5PheaNulh3q2/Ydq+v/I4UpdbIwyJxNXN5KDmo1dMoMOZyJHChHHQ27/Cd26 32ttZxafN6StjJLZDd8S9useW4U3H+E8nzed+4vx0wv/CV2HIXv/qj9ErKfClmj3 30w08qk1iKKrQpOJJhJHqsljgL37sJg1xeB18gCY0V+FgYP/LrQar5dKV3fLp5lH HB4SgJ2ZewTEywCOnM7I/KjSNknuIA== =RL18 -----END PGP SIGNATURE----- --=-=-=--