From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOghT-0004W5-Kh for guix-patches@gnu.org; Tue, 12 Dec 2017 04:18:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOghO-0006Kn-KW for guix-patches@gnu.org; Tue, 12 Dec 2017 04:18:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOghO-0006Kb-Hv for guix-patches@gnu.org; Tue, 12 Dec 2017 04:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOghO-0006s3-CX for guix-patches@gnu.org; Tue, 12 Dec 2017 04:18:02 -0500 Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> Date: Tue, 12 Dec 2017 10:17:08 +0100 In-Reply-To: <87609cluzf.fsf@gmail.com> (Oleg Pykhalov's message of "Tue, 12 Dec 2017 02:12:36 +0300") Message-ID: <87zi6os3u3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 28832@debbugs.gnu.org, Alex Kost Hi Oleg, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> Did you have a chance to investigate the test failures? It=E2=80=99s n= ot >>> confidence-inspiring ;-), so it would be good to at least have a link to >>> an upstream bug report. > > Yes I looked at those tests. Here is a little review of them. > > json-reformat-test:string-to-string basically just calls > a reimplemented in Emacs 25 json-encode-string function. > > json-reformat-test:json-reformat-region-occur-error emulates error and > produce a message. This message is differ from Emacs 24 in symbol '`'. > > So, I think those test fails are harmless. I attach the new patch with > fixing those failing tests. Indeed. > From d589de21acb02d0fba7aee3b48e5f42d7bd8957e Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Tue, 12 Dec 2017 01:41:08 +0300 > Subject: [PATCH] gnu: Add emacs-json-reformat. > > * gnu/packages/patches/emacs-json-reformat-fix-tests.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add this. > * gnu/packages/emacs.scm (emacs-json-reformat): New variable. [...] > diff --git a/gnu/packages/patches/emacs-json-reformat-fix-tests.patch b/g= nu/packages/patches/emacs-json-reformat-fix-tests.patch > new file mode 100644 > index 000000000..23a239582 > --- /dev/null > +++ b/gnu/packages/patches/emacs-json-reformat-fix-tests.patch > @@ -0,0 +1,28 @@ > +Copyright =C2=A9 2017 Oleg Pykhalov > + > +This patch fixes tests for Emacs 25. Please mention here. OK with these changes! > >> Besides, I wonder: shouldn=E2=80=99t =E2=80=98emacs-build-system=E2=80= =99 define the > >> =E2=80=98EMACSLOADPATH=E2=80=99 env. var. so we don=E2=80=99t have to = carry all these -L flags? > >> Is there any downside? >=20 > As I see from the documentation=C2=B9 EMACSLOADPATH is a list of director= ies > with *.el files in it. If we will use it, then it will be almost the > same carring bunch of directories in package recipes, will it? If =E2=80=98emacs-build-system=E2=80=99 sets =E2=80=98EMACSLOADPATH=E2=80= =99 automatically, then individual package definitions won=E2=80=99t need those -L flags. Dunno if there are good reasons not to do so. Maybe Alex has an opinion? Thanks, Ludo=E2=80=99.