From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: guile-gdbm doesn't work with gdbm-1.14
Date: Mon, 19 Mar 2018 11:20:15 +0100
Message-ID: <87zi34cqow.fsf@elephly.net>
References: <874lldvktm.fsf@member.fsf.org> <87efkhebmf.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43173)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1exruL-0007bV-34
	for guix-devel@gnu.org; Mon, 19 Mar 2018 06:20:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1exruH-0005c7-0t
	for guix-devel@gnu.org; Mon, 19 Mar 2018 06:20:49 -0400
Received: from sender-of-o51.zoho.com ([135.84.80.216]:21001)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1exruG-0005bG-N7
	for guix-devel@gnu.org; Mon, 19 Mar 2018 06:20:44 -0400
In-reply-to: <87efkhebmf.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org, guile-user@gnu.org


Mark H Weaver <mhw@netris.org> writes:

> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes:
>
>> Hello, since version 1.14, gdbm doesn't export "gdbm_errno" anymore [1],
>> so the guile-gdbm ffi binding code [2] need updates now (I'm not
>> confident to do it myself...).
>>
>> [1] http://git.gnu.org.ua/cgit/gdbm.git/commit/?id=3Dc175231e2781abd17ea=
bf412cfb597654a076c7b
>> [2] https://github.com/ijp/guile-gdbm/blob/master/gdbm.scm#L156
>
> Here's a preliminary fix.

Thank you.

> * gnu/packages/patches/guile-gdbm-ffi-support-gdbm-1.14.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/guile.scm (guile-gdbm-ffi)[native-inputs]: New field.
> [inputs]: Move above arguments.  Add the patch, and the 'patch' program.
> [propagated-inputs]: Move above arguments.
> [arguments]: In the builder, add code to apply the patch.

I don=E2=80=99t see the native-inputs field in the patch.  Shouldn=E2=80=99=
t the =E2=80=9Cpatch=E2=80=9D
and =E2=80=9Cpatch-file=E2=80=9D inputs be native-inputs?

--=20
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net