From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCHES] gnu: linux-libre: Update to 4.16 Date: Sun, 08 Apr 2018 11:16:33 -0400 Message-ID: <87zi2dsp7y.fsf@netris.org> References: <87fu467tkb.fsf@netris.org> <20180407210616.GA4069@jasmine.lan> <87k1ticxl7.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5C4c-00021m-0H for guix-devel@gnu.org; Sun, 08 Apr 2018 11:17:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5C4X-0000Wn-Ne for guix-devel@gnu.org; Sun, 08 Apr 2018 11:17:41 -0400 Received: from world.peace.net ([50.252.239.5]:51836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5C4X-0000Jy-JQ for guix-devel@gnu.org; Sun, 08 Apr 2018 11:17:37 -0400 In-Reply-To: (Vincent Legoll's message of "Sun, 8 Apr 2018 10:28:06 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vincent Legoll Cc: guix-devel Hi Vincent, Vincent Legoll writes: > On Sun, Apr 8, 2018 at 3:10 AM, Mark H Weaver wrote: >> Leo Famulari writes: >> >>> On Sat, Apr 07, 2018 at 02:36:04PM -0400, Mark H Weaver wrote: >>>> One more thing: I had to add 'flex' and 'bison' as native-inputs because >>>> the build system in 4.16 now concludes that they need to be re-run for >>>> some reason. This could perhaps be avoided by adding a phase to touch >>>> the generated files, but I didn't try it. >>> >>> I noticed this too while building 4.16 with Debian's tooling (`make >>> bindeb-pkg`). >> >> That's interesting. I guess the timestamps in your unpacked source >> directory were probably not zeroed, so I guess that timestamps are not >> the issue here. > > This is not specific to guix / guixsd building the kernel. > > I think that's intentional, the kbuild system has been modified to always > regenerate the files from their sources. > > See lkml discussion: > https://lkml.org/lkml/2017/8/19/49 > > See commit: > 29c833061c1d8c2d1d23a62e7061561eadd76cdb > > Merged in : > 562f36ed28e6faa4245ea2ca1392d90ab98ebbe8 Thank you for getting to the bottom of this, Vincent! Note that although the original proposed patch would have removed _all_ *.c_shipped files in the tree, the merged patch removed only the ones for scripts/kconfig/zconf.{l,y}. The following generated files still remain in the upstream 4.16 tarball: mhw@jojen ~$ find linux-4.16 | egrep '\.tab\.' linux-4.16/scripts/dtc/dtc-parser.tab.c_shipped linux-4.16/scripts/dtc/dtc-parser.tab.h_shipped linux-4.16/scripts/genksyms/parse.tab.c_shipped linux-4.16/scripts/genksyms/parse.tab.h_shipped So, we still have a decision to make: whether to delete these generated files (possibly in a snippet) to avoid using pre-generated non-source files in our build. I would be in favor of it. I'd like to hear opinions on this. Mark