From: Mark H Weaver <mhw@netris.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCHES] gnu: linux-libre: Update to 4.16
Date: Sun, 08 Apr 2018 11:16:33 -0400 [thread overview]
Message-ID: <87zi2dsp7y.fsf@netris.org> (raw)
In-Reply-To: <CAEwRq=p-3y4MHvTMwGGjui0hcCkFj1OqOuwkOJid7LUoimO9tg@mail.gmail.com> (Vincent Legoll's message of "Sun, 8 Apr 2018 10:28:06 +0200")
Hi Vincent,
Vincent Legoll <vincent.legoll@gmail.com> writes:
> On Sun, Apr 8, 2018 at 3:10 AM, Mark H Weaver <mhw@netris.org> wrote:
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Sat, Apr 07, 2018 at 02:36:04PM -0400, Mark H Weaver wrote:
>>>> One more thing: I had to add 'flex' and 'bison' as native-inputs because
>>>> the build system in 4.16 now concludes that they need to be re-run for
>>>> some reason. This could perhaps be avoided by adding a phase to touch
>>>> the generated files, but I didn't try it.
>>>
>>> I noticed this too while building 4.16 with Debian's tooling (`make
>>> bindeb-pkg`).
>>
>> That's interesting. I guess the timestamps in your unpacked source
>> directory were probably not zeroed, so I guess that timestamps are not
>> the issue here.
>
> This is not specific to guix / guixsd building the kernel.
>
> I think that's intentional, the kbuild system has been modified to always
> regenerate the files from their sources.
>
> See lkml discussion:
> https://lkml.org/lkml/2017/8/19/49
>
> See commit:
> 29c833061c1d8c2d1d23a62e7061561eadd76cdb
>
> Merged in :
> 562f36ed28e6faa4245ea2ca1392d90ab98ebbe8
Thank you for getting to the bottom of this, Vincent!
Note that although the original proposed patch would have removed _all_
*.c_shipped files in the tree, the merged patch removed only the ones
for scripts/kconfig/zconf.{l,y}. The following generated files still
remain in the upstream 4.16 tarball:
mhw@jojen ~$ find linux-4.16 | egrep '\.tab\.'
linux-4.16/scripts/dtc/dtc-parser.tab.c_shipped
linux-4.16/scripts/dtc/dtc-parser.tab.h_shipped
linux-4.16/scripts/genksyms/parse.tab.c_shipped
linux-4.16/scripts/genksyms/parse.tab.h_shipped
So, we still have a decision to make: whether to delete these generated
files (possibly in a snippet) to avoid using pre-generated non-source
files in our build. I would be in favor of it.
I'd like to hear opinions on this.
Mark
next prev parent reply other threads:[~2018-04-08 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 18:36 [PATCHES] gnu: linux-libre: Update to 4.16 Mark H Weaver
2018-04-07 21:06 ` Leo Famulari
2018-04-08 1:10 ` Mark H Weaver
2018-04-08 8:28 ` Vincent Legoll
2018-04-08 15:16 ` Mark H Weaver [this message]
2018-04-09 0:35 ` Chris Marusich
2018-04-09 15:38 ` Ludovic Courtès
2018-05-09 6:44 ` Chris Marusich
2018-05-09 8:56 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi2dsp7y.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.