From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIsH6-0003Fx-3Z for guix-patches@gnu.org; Wed, 16 May 2018 04:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIsH0-0002cC-DB for guix-patches@gnu.org; Wed, 16 May 2018 04:59:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fIsH0-0002c8-96 for guix-patches@gnu.org; Wed, 16 May 2018 04:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fIsGz-0001Lx-Un for guix-patches@gnu.org; Wed, 16 May 2018 04:59:01 -0400 Subject: [bug#31458] [PATCH] union: Do not warn about harmless collissions. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180515083119.12788-1-ludo@gnu.org> <20180515142446.524bb6ff@scratchpost.org> Date: Wed, 16 May 2018 10:57:57 +0200 In-Reply-To: <20180515142446.524bb6ff@scratchpost.org> (Danny Milosavljevic's message of "Tue, 15 May 2018 14:29:43 +0200") Message-ID: <87zi10gep6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 31458@debbugs.gnu.org Hello, Danny Milosavljevic skribis: > On Tue, 15 May 2018 10:31:19 +0200 > Ludovic Court=C3=A8s wrote: > >> Until now we'd get pointless messages like: >>=20 >> warning: collision encountered: >> /gnu/store/=E2=80=A6-gtk-icon-themes/share/icons/hicolor/icon-theme.= cache >> /gnu/store/=E2=80=A6-inkscape-0.92.3/share/icons/hicolor/icon-theme.= cache >> warning: choosing /gnu/store/=E2=80=A6-gtk-icon-themes/share/icons/hic= olor/icon-theme.cache > > Hmm, I guess the icon-theme.cache one is harmless enough - however, there= shouldn't > be many of those left anyway. Is there an easy way to check the store of= hydra or something > which packages still have those files? No, but everyone can check in their own profile. :-) > I've fixed inkscape now. Since =E2=80=9Cfixing=E2=80=9D packages like you just did is a manual step,= I think it=E2=80=99s still fine to ignore =E2=80=9Cicon-theme.cache=E2=80=9D collisions. WDYT? >> +(define %harmless-collisions >> + ;; This is a list of files that are known to collide, but for which e= mitting >> + ;; a warning doesn't make sense. For example, "icon-theme.cache" is >> + ;; regenerated by a profile hook which shadows the file provided by >> + ;; individual packages, and "gschemas.compiled" is made available to >> + ;; applications via 'glib-or-gtk-build-system'. >> + '("icon-theme.cache" "gschemas.compiled")) > > However, about gschemas.compiled I'm not sure yet. > > How do we ensure that glib-or-gtk-build-system is actually used for packa= ges that > need it? I don=E2=80=99t think we can. :-/ > libreoffice has some problem that makes it crash every time it tries to o= pen a > file dialog - I wonder if that's related (libreoffice uses gnu-build-syst= em). It is, see . > But glib-or-gtk-build-system expicitly generates gschemas.compiled, ensur= ing a > collision - what's up with that? glib-or-gtk-build-system wraps binaries so that they refer to the right gschemas.compiled, so in that case the gschemas.compiled file that ends up in the profile doesn=E2=80=99t matter at all. > Shouldn't there be a profile hook for it instead? There doesn't seem to = be one. Maybe, yes, though I=E2=80=99m not sure how that=E2=80=99d work (and would = it be fast enough?). This seems to be orthogonal to this patch, though: we can remove the collision warnings for these files today, because there=E2=80=99s nothing u= sers can do about them and they=E2=80=99re effectively harmless, and later on, i= f we have better gschemas.compiled handling, we can always let them through again. Thoughts? Ludo=E2=80=99.