From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40931)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fP77X-0006nY-CS
	for guix-patches@gnu.org; Sat, 02 Jun 2018 10:03:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fP77W-0000DK-Aa
	for guix-patches@gnu.org; Sat, 02 Jun 2018 10:03:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51545)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fP77W-0000Cq-6p
	for guix-patches@gnu.org; Sat, 02 Jun 2018 10:03:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fP77V-00067K-Tw
	for guix-patches@gnu.org; Sat, 02 Jun 2018 10:03:01 -0400
Subject: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Resent-Message-ID: <handler.31514.B31514.152794814923469@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180518184910.9987-16-ambrevar@gmail.com>
	<20180601075051.28276-1-ambrevar@gmail.com>
Date: Sat, 02 Jun 2018 16:02:21 +0200
In-Reply-To: <20180601075051.28276-1-ambrevar@gmail.com> (Pierre Neidhardt's
	message of "Fri, 1 Jun 2018 09:50:51 +0200")
Message-ID: <87zi0d5lsi.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31514@debbugs.gnu.org

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.

[...]

> +  (package
> +    (name "emacs-gif-screencast")
> +    (version "20180309")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
> +             "825e606950ec842304bf75cf85baef707b853b03"
> +             ".tar.gz"))

Could you use the usual scheme for version numbers of Git snapshots
(info "(guix) Version Numbers")?

> +    (propagated-inputs
> +     `(("scrot" ,scrot)
> +       ("imagemagick" ,imagemagick)
> +       ("gifsicle" ,gifsicle)))

Instead of propagating these, which could =E2=80=9Cpollute=E2=80=9D the use=
r=E2=80=99s profile,
could you hardcode the absolute file names of these programs in the .el
files?  See how this is done for EMMS, for instance.

> +    (home-page
> +     "https://github.com/Ambrevar/emacs-gif-screencast")
> +    (synopsis "One-frame-per-action GIF recording")

This looks very useful!

TIA!

Ludo=E2=80=99.