From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSRy5-0006CX-M5 for guix-patches@gnu.org; Mon, 11 Jun 2018 14:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSRy2-00085x-Be for guix-patches@gnu.org; Mon, 11 Jun 2018 14:55:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSRy2-00085m-79 for guix-patches@gnu.org; Mon, 11 Jun 2018 14:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSRy2-00026q-0S for guix-patches@gnu.org; Mon, 11 Jun 2018 14:55:02 -0400 Subject: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode. Resent-Message-ID: References: <20180324155920.970-1-mail@cbaines.net> <87370mk9j6.fsf@fastmail.com> From: Christopher Baines In-reply-to: <87370mk9j6.fsf@fastmail.com> Date: Mon, 11 Jun 2018 19:54:47 +0100 Message-ID: <87zi012lxk.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30925@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable. > > [...] > >> +(define-public emacs-puppet-mode >> + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2") >> + (revision "1")) >> + (package >> + (name "emacs-puppet-mode") >> + (version (git-version "0.3" revision commit)) > > Maybe mention why we can't take the 0.3 tag? I've sent a new patch with a comment. >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://raw.githubusercontent.com/voxpupuli/puppet-mode/" >> + commit "/puppet-mode.el")) > > It would be nice to install the README too, but no strong opinion. I've gone for leaving it out for now, just to keep the package simple. >> + (sha256 >> + (base32 >> + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm")))) >> + (build-system emacs-build-system) >> + (home-page "https://github.com/voxpupuli/puppet-mode") >> + (synopsis "Emacs major mode for the Puppet configuration language") >> + (description >> + "This package provides support for the Puppet configuration language, >> +including syntax highlighting, indentation of expressions and statements, >> +linting of manifests and integration with Puppet Debugger.") >> + (license license:gpl3+)))) > > Perhaps mention in a comment that it includes ASL code, as mentioned in > puppet-mode.el. I've added this now :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlsexXdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XddhRAAtCKUCd6eA+449AXy94dX5PdF7mFvW14T1HoMOG8lID6OXJ1MgpMu3qby UaDTuWt/K5Ll6gq/EiU1N5vtAnk9zku9xiOX+eR8jDp608PX5RD8fMA6UZniwkLK ezDPuCr5g2TT545VV4yLlKVEY1b5hHYbh0Cc3IsheJJ0EYPhwVuXVlbz+i/LQBIB YC1z3BZppMqTTDuNFzy0C/wk+TvCs9SgLYSBHtWjjou2NshIzfwwoEF51GuhhLLe U0JnkghmjjiO4Mg1j25GdH7Iqu9hNbRFFyTVHuTwqMMpuvNN/a2CcFcF3Rkp9b9+ C8E/nDAyjuUhpjF//PasaD479pAQH5i1NqAhZC6qw3malbd3NnEW8pB4IkH6S6FK 9XoUInuLtLAjk9iY2P+/VAyiNKPx9DTkP0VOFCSbBknoalw18dqHQolNzM3UORI5 jrc0BnqwEXr6Sx5q3HSjhcTJf5fL8Yy4L1bgAyzdxyMYPmMLjyaVNYQ0yvtp3utX fmVCytVcAIdR/hVX/MA4Ute/k5SRJ8uJ2Cf8zdg9n9C/iFnye82lpIEi8jSYlLJn BDqehLany1EoaFlAIBpvEn5G25X7hoIOYgy49jrGhWavcNR9U0CnO9jpehTFnoZJ T4XHhdFQaD/xFzYF0eT+mU/PD1airdHFbWPPP6sgJf0zY7lQOFw= =Z1LP -----END PGP SIGNATURE----- --=-=-=--