From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52284)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXNJ3-0001M4-Bl
	for guix-patches@gnu.org; Mon, 25 Jun 2018 04:57:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXNJ0-0000NZ-9i
	for guix-patches@gnu.org; Mon, 25 Jun 2018 04:57:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54603)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fXNJ0-0000NV-6M
	for guix-patches@gnu.org; Mon, 25 Jun 2018 04:57:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fXNIz-0000nf-Up
	for guix-patches@gnu.org; Mon, 25 Jun 2018 04:57:01 -0400
Subject: [bug#31911] [PATCH] services: Add
	prometheus-node-exporter-service-type.
Resent-Message-ID: <handler.31911.B31911.15299169933038@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180620125946.7264-1-boskovits@gmail.com>
	<87po0hw4r4.fsf@gnu.org>
	<CAE4v=ph+pa=Vw6zkd4XpOcaa2pOu4+6+oprULj_TvAh4uyOacw@mail.gmail.com>
Date: Mon, 25 Jun 2018 10:56:19 +0200
In-Reply-To: <CAE4v=ph+pa=Vw6zkd4XpOcaa2pOu4+6+oprULj_TvAh4uyOacw@mail.gmail.com>
	("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Mon, 25 Jun 2018
	10:31:45 +0200")
Message-ID: <87zhzjqm6k.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@gmail.com>
Cc: 31911@debbugs.gnu.org

Hello,

G=C3=A1bor Boskovits <boskovits@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> ezt =C3=ADrta (id=C5=91pont: 2018. j=
=C3=BAn. 23., Szo,
> 23:51):

[...]

>> That=E2=80=99s very useful!  Hopefully we can start using it on our buil=
d farm,
>> though we=E2=80=99ll need Grafena (?) or something to visualize those st=
ats,
>> right?  OTOH apparently it already provides a web interface, so=E2=80=A6?
>>
>>
> This is actually only one half of the solution, this provides an endpoint
> for
> the prometheus server to scrape. I've not yet packaged the server part.
> The server has the needed visualization capabilities.

OK, I see.

>> +@deftp {Data Type} prometheus-node-exporter-configuration
>> > +Data type representing the configuration of @command{node_exporter}.
>> > +
>> > +@table @asis
>> > +@item @code{package} (default:
>> @code{go-github-com-prometheus-node-exporter})
>> > +The prometheus-node-exporter package to use.
>> > +@item @code{web-listen-address} (default: @code{":9100"})
>> > +Bind the web interface to the specified address.
>>
>> Please add a newline before the second @item.
>>
>>
> Most of these were copied almost verbatim form darkstat service. Maybe
> these modification should be also applied there.
> Will send an updated patch. Should I contact Sou Bunnbu regadring the
> darkstat documentation, or should I fix it?

You can go ahead and fix them as a separate commit.

Thanks,
Ludo=E2=80=99.