From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32871)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ffXLD-0007an-PO
	for guix-patches@gnu.org; Tue, 17 Jul 2018 17:17:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ffXLC-0003SB-CJ
	for guix-patches@gnu.org; Tue, 17 Jul 2018 17:17:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40819)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ffXLC-0003Rp-7R
	for guix-patches@gnu.org; Tue, 17 Jul 2018 17:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ffXLC-00016f-1C
	for guix-patches@gnu.org; Tue, 17 Jul 2018 17:17:02 -0400
Subject: [bug#32155] [PATCH 0/4] sfml updates
Resent-Message-ID: <handler.32155.B32155.15318621744192@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180714144121.30906-1-mbakke@fastmail.com>
Date: Tue, 17 Jul 2018 23:16:03 +0200
In-Reply-To: <20180714144121.30906-1-mbakke@fastmail.com> (Marius Bakke's
	message of "Sat, 14 Jul 2018 16:41:21 +0200")
Message-ID: <87zhyp7ecs.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 32155@debbugs.gnu.org

Hello Marius,

Marius Bakke <mbakke@fastmail.com> skribis:

> This series updates sfml to the latest release, and adds some of the
> "stb" <https://github.com/nothings/stb> libraries in order to unbundle
> all dependencies.
>
> Marius Bakke (4):
>   gnu: sfml: Update to 2.5.0.
>   gnu: Add stb-image.
>   gnu: Add stb-image-write.
>   gnu: sfml: Remove all bundled dependencies.

It all LGTM!

> +(define (make-stb-header-package name version description)
> +  (package
> +    (inherit stb)
> +    (name name)
> +    (version version)
> +    (source #f)
> +    (inputs `(("stb" ,stb)))
> +    (build-system trivial-build-system)
> +    (arguments
> +     `(#:modules ((guix build utils))
> +       #:builder (begin
> +                   (use-modules (guix build utils))
> +                   (let ((stb (assoc-ref %build-inputs "stb"))
> +                         (lib (string-join (string-split ,name #\-) "_"))
> +                         (out (assoc-ref %outputs "out")))
> +                     (install-file (string-append stb "/" lib ".h")
> +                                   (string-append out "/include"))
> +                     #t))))
> +    (description description)))
> +
> +(define-public stb-image
> +  (make-stb-header-package
> +   "stb-image" "2.19"
> +   "stb-image is a small and self-contained library for image loading or
> +decoding from file or memory.  A variety of formats are supported."))

Not sure if it really matters here, but note that the description here
won=E2=80=99t be subject to translation.

To make it translatable, it would have to be embedded in a (description
"=E2=80=A6") form.  I address that with phony macros as in
=E2=80=98define-word-list-dictionary=E2=80=99 in aspell.scm.

Thanks,
Ludo=E2=80=99.