Magit interactive rebase error: perl not found

Magit interactive rebase error: perl not found

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

When rebasing interactively with Magit, I get the following error

--8<---------------cut here---------------start------------->8---
  1 git … rebase -i d64bc3b\^
/home/ambrevar/.guix-profile/libexec/git-core/git-rebase--interactive: line 277: perl: command not found
Could not execute editor
--8<---------------cut here---------------end--------------->8---

From commandline it works fine.  If I install perl in my user profile,
it works too.

I suspect some defvar patch to be missing.

Anyone else?

-- 
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Magit interactive rebase error: perl not found

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Pierre Neidhardt <ambrevar@gmail.com> writes:

> When rebasing interactively with Magit, I get the following error
>
>   1 git … rebase -i d64bc3b\^
> /home/ambrevar/.guix-profile/libexec/git-core/git-rebase--interactive: line 277: perl: command not found
> Could not execute editor
>
> From commandline it works fine.  If I install perl in my user profile,
> it works too.
>
> I suspect some defvar patch to be missing.
>
> Anyone else?

I don't use Magit, so I can't say.  What's in the
git-rebase--interactive file on line 277?  In my case, it's this:

267    git_sequence_editor () {
268        if test -z "$GIT_SEQUENCE_EDITOR"
269        then
270            GIT_SEQUENCE_EDITOR="$(git config sequence.editor)"
271            if [ -z "$GIT_SEQUENCE_EDITOR" ]
272            then
273                GIT_SEQUENCE_EDITOR="$(git var GIT_EDITOR)" || return $?
274            fi
275        fi
276
277        eval "$GIT_SEQUENCE_EDITOR" '"$@"'
278    }

Assuming it's the same for you, it would be interesting to see what the
value of $GIT_SEQUENCE_EDITOR and $@ are in this case.  Maybe you could
hack together a custom Git package to figure it out?

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Magit interactive rebase error: perl not found

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

OK, I figured it out, it's in the `magit--cherry-move' function:

--8<---------------cut here---------------start------------->8---
                   (push (format "%s=perl -i -ne '/^pick (%s)/ or print'"
                                 "GIT_SEQUENCE_EDITOR"
                                 (mapconcat #'magit-rev-abbrev commits "|"))
                         process-environment)
--8<---------------cut here---------------end--------------->8---

This "perl" could not be automatically detected by the Guix path-patchers.

We could patch this but I think this also deserves an upstream fix:

	https://github.com/magit/magit/issues/3537

-- 
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]