From: "Clément Lassieur" <clement@lassieur.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 32300-done@debbugs.gnu.org
Subject: bug#32300: [PATCH] database: Fix the builds limit issue.
Date: Thu, 16 Aug 2018 22:59:39 +0200 [thread overview]
Message-ID: <87zhxm3u4k.fsf@lassieur.org> (raw)
In-Reply-To: <20180809075709.44883c92@scratchpost.org> Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi,
>
> On Sat, 04 Aug 2018 18:10:51 +0200
> Clément Lassieur <clement@lassieur.org> wrote:
>
>> Clément Lassieur <clement@lassieur.org> writes:
>>
>> > Fixes <https://bugs.gnu.org/32300>.
>> >
>> > * src/cuirass/database.scm (filters->order): New procedure.
>> > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS,
>> > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT JOIN
>> > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched.
>>
>> This may be less efficient because there are more SQL queries (one per
>> output), but it's way less complicated and less buggy, so I think it's
>> worth it.
>
> Yeah, if it's still usable, I agree.
>
> But I think we shouldn't overlook the possibility of not fetching the outputs
> in the first place (at all).
Pushed. Thank you for the review!
Clément
prev parent reply other threads:[~2018-08-16 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 23:21 bug#32300: Cuirass: the 'nr' filter doesn't when builds have multiple outputs Clément Lassieur
2018-07-28 23:26 ` bug#32300: Cuirass: the 'nr' filter doesn't work " Clément Lassieur
2018-08-04 16:00 ` bug#32300: [PATCH] database: Fix the builds limit issue Clément Lassieur
2018-08-04 16:10 ` Clément Lassieur
2018-08-07 10:46 ` Danny Milosavljevic
2018-08-08 11:44 ` Clément Lassieur
2018-08-08 15:32 ` Clément Lassieur
2018-08-09 5:57 ` Danny Milosavljevic
2018-08-09 8:02 ` Clément Lassieur
2018-08-16 20:59 ` Clément Lassieur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhxm3u4k.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=32300-done@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.