Re: 01/01: gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.

Re: 01/01: gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.

[Mark H Weaver]

Hi Efraim,

guix-commits@gnu.org writes:

> efraim pushed a commit to branch master
> in repository guix.
>
> commit 454e7132d6fffb5c9a5ce086ffd1b687416feb83
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Sat Dec 1 22:41:19 2018 +0200
>
>     gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.
>     
>     * gnu/packages/ocaml.scm (ocaml@4.01)[supported-systems]: New field.

What's the rationale for this change?
Debian includes OCaml 4.01 in its arm64 port.

  https://packages.debian.org/search?arch=arm64&keywords=ocaml
  http://http.us.debian.org/debian/pool/main/o/ocaml/ocaml_4.01.0-5_arm64.deb

      Mark

Re: 01/01: gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2704 bytes --]

On Sat, Dec 01, 2018 at 05:23:32PM -0500, Mark H Weaver wrote:
> Hi Efraim,
> 
> guix-commits@gnu.org writes:
> 
> > efraim pushed a commit to branch master
> > in repository guix.
> >
> > commit 454e7132d6fffb5c9a5ce086ffd1b687416feb83
> > Author: Efraim Flashner <efraim@flashner.co.il>
> > Date:   Sat Dec 1 22:41:19 2018 +0200
> >
> >     gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.
> >     
> >     * gnu/packages/ocaml.scm (ocaml@4.01)[supported-systems]: New field.
> 
> What's the rationale for this change?
> Debian includes OCaml 4.01 in its arm64 port.
> 
>   https://packages.debian.org/search?arch=arm64&keywords=ocaml
>   http://http.us.debian.org/debian/pool/main/o/ocaml/ocaml_4.01.0-5_arm64.deb
> 
>       Mark

starting phase `configure'
../gnu/config.guess: unable to guess system type

This script, last modified 2011-11-11, has failed to recognize
the operating system you are using. It is advised that you
download the most up to date version of the config scripts from

  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
and
  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD

If the version you run (../gnu/config.guess) is already up to date, please
send the following data and any information you think might be
pertinent to <config-patches@gnu.org> in order to provide the needed
information to handle your system.

config.guess timestamp = 2011-11-11

uname -m = aarch64
uname -r = 4.4.52
uname -s = Linux
uname -v = #19 SMP Tue May 2 11:36:30 HKT 2017

/usr/bin/uname -p =
/bin/uname -X     =

hostinfo               =
/bin/universe          =
/usr/bin/arch -k       =
/bin/arch              =
/usr/bin/oslevel       =
/usr/convex/getsysinfo =

UNAME_MACHINE = aarch64
UNAME_RELEASE = 4.4.52
UNAME_SYSTEM  = Linux
UNAME_VERSION = #19 SMP Tue May 2 11:36:30 HKT 2017
Cannot guess host type
You must specify one with the -host option


I tried Debian's autoreconf plan, where every package gets "autoreconf
-vfi" before configure, but there was no configure.ac in the source.
After looking through the included configure script, it checks for
arm*-*-*-*, so adding "-host" "arm64-unknown-linux-gnu" made it pass the
configure phase. There is more work needed to make it actually build,
but it looks like it is possible.

It still fails to build, but it's at least getting much closer. I'll fix
that.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 01/01: gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Sat, Dec 01, 2018 at 05:23:32PM -0500, Mark H Weaver wrote:
>> Hi Efraim,
>> 
>> guix-commits@gnu.org writes:
>> 
>> > efraim pushed a commit to branch master
>> > in repository guix.
>> >
>> > commit 454e7132d6fffb5c9a5ce086ffd1b687416feb83
>> > Author: Efraim Flashner <efraim@flashner.co.il>
>> > Date:   Sat Dec 1 22:41:19 2018 +0200
>> >
>> >     gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.
>> >     
>> >     * gnu/packages/ocaml.scm (ocaml@4.01)[supported-systems]: New field.
>> 
>> What's the rationale for this change?
>> Debian includes OCaml 4.01 in its arm64 port.
>> 
>>   https://packages.debian.org/search?arch=arm64&keywords=ocaml
>>   http://http.us.debian.org/debian/pool/main/o/ocaml/ocaml_4.01.0-5_arm64.deb
>> 
>>       Mark
>
> starting phase `configure'
> ../gnu/config.guess: unable to guess system type

Would it be enough to add Automake as a native input and copy
‘config.guess’ from there?

If not, I think it’d be good to add a comment above ‘supported-systems’
explaining why we remove a specific system.

Thanks,
Ludo’.

Re: 01/01: gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> Efraim Flashner <efraim@flashner.co.il> skribis:
>
>> On Sat, Dec 01, 2018 at 05:23:32PM -0500, Mark H Weaver wrote:
>>> Hi Efraim,
>>> 
>>> guix-commits@gnu.org writes:
>>> 
>>> > efraim pushed a commit to branch master
>>> > in repository guix.
>>> >
>>> > commit 454e7132d6fffb5c9a5ce086ffd1b687416feb83
>>> > Author: Efraim Flashner <efraim@flashner.co.il>
>>> > Date:   Sat Dec 1 22:41:19 2018 +0200
>>> >
>>> >     gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.
>>> >     
>>> >     * gnu/packages/ocaml.scm (ocaml@4.01)[supported-systems]: New field.
>>> 
>>> What's the rationale for this change?
>>> Debian includes OCaml 4.01 in its arm64 port.
>>> 
>>>   https://packages.debian.org/search?arch=arm64&keywords=ocaml
>>>   http://http.us.debian.org/debian/pool/main/o/ocaml/ocaml_4.01.0-5_arm64.deb
>>> 
>>>       Mark
>>
>> starting phase `configure'
>> ../gnu/config.guess: unable to guess system type
>
> Would it be enough to add Automake as a native input and copy
> ‘config.guess’ from there?

Ideally, we shouldn't need 'config.guess' at all.  Normally, it is only
used if the GNU triplet is not explicitly passed to ./configure.  A few
years ago, I fixed most instances of this problem by unconditionally
passing --build=<triplet> to ./configure in the default 'configure'
phase of gnu-build-system.

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3c7d023d6458669c6bfa23bc85e098c91f699892

However, our OCaml package has a custom 'configure' phase that does not
pass --build.  I'm not sure if that's because OCaml's configure phase
doesn't support --build, or if it was omitted because it's not typically
needed on x86_64.

* * *

Anyway, more generally, I hope that we will not get in the habit of
simply removing systems from 'supported-systems' when builds fail on
those systems, without investigating and concluding that it would be
prohibitively difficult to support the software on that system.

To my mind, it's *good* to see failed builds on other architectures, to
be reminded of bugs on non-x86_64 systems that should be fixed.  When we
remove systems from 'supported-systems' without good reason, this is
somewhat analogous to deleting unfixed bug reports.

What do you think?

      Mark

Re: 01/01: gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]

On Sun, Dec 02, 2018 at 03:51:58PM -0500, Mark H Weaver wrote:
> ludo@gnu.org (Ludovic Courtès) writes:
> 
> > Efraim Flashner <efraim@flashner.co.il> skribis:
> >
> >> On Sat, Dec 01, 2018 at 05:23:32PM -0500, Mark H Weaver wrote:
> >>> Hi Efraim,
> >>> 
> >>> guix-commits@gnu.org writes:
> >>> 
> >>> > efraim pushed a commit to branch master
> >>> > in repository guix.
> >>> >
> >>> > commit 454e7132d6fffb5c9a5ce086ffd1b687416feb83
> >>> > Author: Efraim Flashner <efraim@flashner.co.il>
> >>> > Date:   Sat Dec 1 22:41:19 2018 +0200
> >>> >
> >>> >     gnu: ocaml@4.01: Remove aarch64-linux from supported-systems.
> >>> >     
> >>> >     * gnu/packages/ocaml.scm (ocaml@4.01)[supported-systems]: New field.
> >>> 
> >>> What's the rationale for this change?
> >>> Debian includes OCaml 4.01 in its arm64 port.
> >>> 
> >>>   https://packages.debian.org/search?arch=arm64&keywords=ocaml
> >>>   http://http.us.debian.org/debian/pool/main/o/ocaml/ocaml_4.01.0-5_arm64.deb
> >>> 
> >>>       Mark
> >>
> >> starting phase `configure'
> >> ../gnu/config.guess: unable to guess system type
> >
> > Would it be enough to add Automake as a native input and copy
> > ‘config.guess’ from there?
> 
> Ideally, we shouldn't need 'config.guess' at all.  Normally, it is only
> used if the GNU triplet is not explicitly passed to ./configure.  A few
> years ago, I fixed most instances of this problem by unconditionally
> passing --build=<triplet> to ./configure in the default 'configure'
> phase of gnu-build-system.
> 
>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3c7d023d6458669c6bfa23bc85e098c91f699892
> 
> However, our OCaml package has a custom 'configure' phase that does not
> pass --build.  I'm not sure if that's because OCaml's configure phase
> doesn't support --build, or if it was omitted because it's not typically
> needed on x86_64.
> 
> * * *
> 
> Anyway, more generally, I hope that we will not get in the habit of
> simply removing systems from 'supported-systems' when builds fail on
> those systems, without investigating and concluding that it would be
> prohibitively difficult to support the software on that system.
> 
> To my mind, it's *good* to see failed builds on other architectures, to
> be reminded of bugs on non-x86_64 systems that should be fixed.  When we
> remove systems from 'supported-systems' without good reason, this is
> somewhat analogous to deleting unfixed bug reports.
> 
> What do you think?
> 
>       Mark

I looked back at the "state of aarch64 in guix¹" blog post, which stated:
OCaml 4.01.0: Doesn't build on aarch64, haven't investigated.

I believe this is the first one that I've marked unsupported in quite a
while, but adding a note as to why it's labeled unsupported would be
best; it gives us the best chance possible at revisiting the decision
later.

¹http://guix.info/blog/2017/state-of-aarch64-on-guix/

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]