From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVFsV-0006km-Ll for guix-patches@gnu.org; Fri, 07 Dec 2018 08:09:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVFsS-0004rU-I0 for guix-patches@gnu.org; Fri, 07 Dec 2018 08:09:11 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gVFsM-0004hc-BV for guix-patches@gnu.org; Fri, 07 Dec 2018 08:09:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gVFsL-0002Di-W2 for guix-patches@gnu.org; Fri, 07 Dec 2018 08:09:02 -0500 Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. Resent-Message-ID: From: Maxim Cournoyer References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> <87k1knpjta.fsf@gmail.com> <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> Date: Fri, 07 Dec 2018 08:08:13 -0500 In-Reply-To: <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> (swedebugia's message of "Thu, 06 Dec 2018 04:31:28 -0800") Message-ID: <87zhthmqma.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: swedebugia@riseup.net Cc: 33575@debbugs.gnu.org, Guix-patches swedebugia@riseup.net writes: > On 2018-12-06 01:42, Oleg Pykhalov wrote: >> Hello, >>=20 >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>=20 >> [=E2=80=A6] >>=20 >>> It=E2=80=99s something we rarely do so we=E2=80=99d get warnings for mo= st packages. As >>> a side effect, people may pay less attention to what =E2=80=98guix lint= =E2=80=99 says. >>=20 >> I think this should not stop us from improving a linter and an option >> like --misc-checks=3Dsort-input,foo,bar could be used for such cases. > > I agree with Oleg here.=20 > > If many packages needs inputs to be sorted lets write a guix lint --sort > modelling the updater (that is make the changes in the work tree to be > committed). +1