From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:59954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggmwc-0003nU-0h
	for guix-patches@gnu.org; Tue, 08 Jan 2019 03:41:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggmwZ-000738-4E
	for guix-patches@gnu.org; Tue, 08 Jan 2019 03:41:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:49930)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ggmwY-000725-Qb
	for guix-patches@gnu.org; Tue, 08 Jan 2019 03:41:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ggmwX-00019J-Mp
	for guix-patches@gnu.org; Tue, 08 Jan 2019 03:41:01 -0500
Subject: [bug#33801] import: github: Support source URIs that redirect to
	GitHub
Resent-Message-ID: <handler.33801.B33801.15469368214363@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <cu7imzpokxn.fsf@systemreboot.net> <87d0pxtciz.fsf@gnu.org>
	<cu7mup04rfp.fsf@systemreboot.net> <87woo4qxg7.fsf@gnu.org>
	<cu77eg44a9f.fsf@systemreboot.net> <87k1k4p3gl.fsf@gnu.org>
	<cu7h8f8b0vc.fsf@systemreboot.net> <cu77eg3awvc.fsf@systemreboot.net>
	<877eg2q56k.fsf@gnu.org> <cu7y38han6g.fsf@systemreboot.net>
	<87o98uzo9u.fsf@gnu.org> <cu78szw8ilg.fsf@systemreboot.net>
Date: Tue, 08 Jan 2019 09:40:14 +0100
In-Reply-To: <cu78szw8ilg.fsf@systemreboot.net> (Arun Isaac's message of "Mon,
	07 Jan 2019 23:18:11 +0530")
Message-ID: <87zhsb1r0x.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33801@debbugs.gnu.org

Hello,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> This is a simple mistake on my part and it's not because stellarium's
> origin URI redirects to the github-production-release-asset URI. Please
> find attached a patch addressing this.
>
> From a8bc92f507e35b54afdd24a42f0aa45ff7cb2c0b Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Mon, 7 Jan 2019 23:11:58 +0530
> Subject: [PATCH] guix: lint: Warn only if GitHub URI is not same as the
>  package URI.
>
> * guix/scripts/lint.scm (check-github-url): Warn only if the GitHub URI
> obtained after following redirects is not same as the original URI.

Oh, I see.  Perhaps we should add a test to catch this specific case so
that it doesn=E2=80=99t pop up again?

Otherwise LGTM.

Thanks,
Ludo=E2=80=99.