From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyLec-0004YW-SE for guix-patches@gnu.org; Mon, 25 Feb 2019 14:11:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyLeb-0002js-QS for guix-patches@gnu.org; Mon, 25 Feb 2019 14:11:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyLeY-0002hq-9z for guix-patches@gnu.org; Mon, 25 Feb 2019 14:11:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gyLeX-0001tD-RA for guix-patches@gnu.org; Mon, 25 Feb 2019 14:11:01 -0500 Subject: [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Resent-Message-ID: References: <20190225151705.17655-1-mail@ambrevar.xyz> <871s3vq4fw.fsf@ambrevar.xyz> From: Christopher Baines In-reply-to: <871s3vq4fw.fsf@ambrevar.xyz> Date: Mon, 25 Feb 2019 19:10:12 +0000 Message-ID: <87zhqjfzvv.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 34650@debbugs.gnu.org --=-=-= Content-Type: text/plain Hey, Thanks for these patches Pierre, I haven't looked at them in detail, but one I did spot was ruby-tilt. I've already sent a patch for that here [1]. In fact, maybe have a look through the patches in that bug, as that will at least give you an idea of how I've been packaging some Ruby gems recently. 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34514#68 Pierre Neidhardt writes: > I've never touched Ruby before, so I've got a bunch of questions: > > - Almost none of the tests pass. Anyone knows what's going on? I haven't checked the patch, but often the test suites are omitted from the archives published to rubygems.org. This avoids users who use the rubygems package manager from downloading the tests unnecessarily (as I don't believe rubygems provides a way to run the tests), but obviously doesn't suit packaging for Guix. Fetching from the version control repository is a good way of getting all the tests, but obviously that isn't what the gem importer generates. > - ruby-sinatra 'install phase hangs forever (i.e. several minutes at > least). I suspect an infinite loop, and it's quite weird this is > happening at the 'install phase. I think theres a commit on the staging branch to pass the --verbose flag to gem install, which may be revealing. > - Should mailcatcher be packaged as "ruby-mailcatcher" or "mailcatcher"? In my opinion, if you think someone might use it as a Ruby library, stick with the ruby- prefix for consistency. Otherwise, call it what you think makes most sense. > - Mailcatcher seems to depend on older version of some packages, > e.g. version 1.0.9.1 of ruby-eventmachine. What's the commended > procedure then? If you're confident that the more recent versions of the dependencies work, then I'd recommend patching the source to loosen the dependency constraints. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlx0PZRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcvRhAAiUVkKmfqUVWoBM/CBxuEqNyC4fd4iKvHqB9uMMEpwc7VkjQqni0+xuuP nW+zBgZYepg3IoW6qy77XzpMTxYUWPosD6WM8xHZuuPiAXbb31eVdKqqYc8RHBMr +wyUZrL3+UGTF89u1kKWtCCJ03k37a3i3Ulvpx5/4HBjxB8uKZEIK0PXBweKa7Nb ylxDdBeG3m5AxsdbvP90nl4pxutuU7S+tdJwBBJW/X1Le47JCb/x306ASONRhMdj LS+wD+6QKp1E+/vW/a7BdCjZVZoJRak1Ni9+iW704MsaGhYIB9jl3KYaEBBLTjRO njJHoHD+m6TEHGfcoU/1ZdNbw5XL/VLliwN7XAQezagJTNEqgeKcZhudL0SZeThW MmFUSd3C+XwfIw2e/1C0ypjFarQjnwELUBOgYLJVUQ2E39qZHK79YQAWeNCFcuC4 QmYRQVae+0NWlPsOUjiypyGyKtgYwvEjSsanYSE2i4IsMba+14w7SD/+IbXI+HAp 6BTByBxTDFW287ADJXCYv+ejfljhuQot8PDYNgQ0rhHPZ4RG1Y0Da8r1XzlWuX6c Dihyk+t/mEXbooqoO5ODwYFPtfAI2Pja5LLP8CXMVZ/C+eTqAu3vhQaKST84H+7+ pTsKLp39RiIwxuyt9wwQHl1lxzWHFJw8RAHOoaijis72UK9gRRo= =BDRk -----END PGP SIGNATURE----- --=-=-=--