From: Christopher Baines <mail@cbaines.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34650@debbugs.gnu.org
Subject: [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft)
Date: Mon, 25 Feb 2019 19:10:12 +0000 [thread overview]
Message-ID: <87zhqjfzvv.fsf@cbaines.net> (raw)
In-Reply-To: <871s3vq4fw.fsf@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]
Hey,
Thanks for these patches Pierre, I haven't looked at them in detail, but
one I did spot was ruby-tilt. I've already sent a patch for that here
[1]. In fact, maybe have a look through the patches in that bug, as that
will at least give you an idea of how I've been packaging some Ruby gems
recently.
1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34514#68
Pierre Neidhardt <mail@ambrevar.xyz> writes:
> I've never touched Ruby before, so I've got a bunch of questions:
>
> - Almost none of the tests pass. Anyone knows what's going on?
I haven't checked the patch, but often the test suites are omitted from
the archives published to rubygems.org. This avoids users who use the
rubygems package manager from downloading the tests unnecessarily (as I
don't believe rubygems provides a way to run the tests), but obviously
doesn't suit packaging for Guix.
Fetching from the version control repository is a good way of getting
all the tests, but obviously that isn't what the gem importer generates.
> - ruby-sinatra 'install phase hangs forever (i.e. several minutes at
> least). I suspect an infinite loop, and it's quite weird this is
> happening at the 'install phase.
I think theres a commit on the staging branch to pass the --verbose flag
to gem install, which may be revealing.
> - Should mailcatcher be packaged as "ruby-mailcatcher" or "mailcatcher"?
In my opinion, if you think someone might use it as a Ruby library,
stick with the ruby- prefix for consistency. Otherwise, call it what you
think makes most sense.
> - Mailcatcher seems to depend on older version of some packages,
> e.g. version 1.0.9.1 of ruby-eventmachine. What's the commended
> procedure then?
If you're confident that the more recent versions of the dependencies
work, then I'd recommend patching the source to loosen the dependency
constraints.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2019-02-25 19:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 15:17 [bug#34650] [PATCH] ruby-mailcatcher: Draft Pierre Neidhardt
[not found] ` <handler.34650.B.155110784318701.ack@debbugs.gnu.org>
2019-02-25 15:21 ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-02-25 19:10 ` Christopher Baines [this message]
2019-02-26 10:59 ` Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 1/7] gnu: ruby-rack-protection: Update to 2.0.5 Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 2/7] gnu: Add ruby-tilt Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann Pierre Neidhardt
2019-03-04 21:20 ` Christopher Baines
2019-02-28 17:44 ` [bug#34650] [PATCH 4/7] gnu: Add ruby-sinatra Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 5/7] gnu: Add ruby-thin Pierre Neidhardt
2019-03-04 21:33 ` Christopher Baines
2019-02-28 17:44 ` [bug#34650] [PATCH 6/7] gnu: Add ruby-skinny Pierre Neidhardt
2019-03-04 21:43 ` Christopher Baines
2019-02-28 17:44 ` [bug#34650] [PATCH 7/7] gnu: Add mailcatcher Pierre Neidhardt
2019-03-04 21:50 ` Christopher Baines
2019-03-05 9:09 ` Pierre Neidhardt
2019-03-05 10:27 ` Pierre Neidhardt
2019-03-05 18:51 ` Christopher Baines
2019-02-28 17:47 ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-03-04 21:06 ` Christopher Baines
2019-03-05 9:18 ` Pierre Neidhardt
2019-03-05 18:51 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhqjfzvv.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=34650@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.