From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: custom kernel config
Date: Mon, 08 Apr 2019 16:52:36 +0200
Message-ID: <87zhp0v9aj.fsf@gnu.org>
References: <20190401180434.GF21029@macbook41> <87wokb1pg1.fsf@gmail.com>
	<20190403190404.GB1203@macbook41>
	<871s2iuavs.fsf@mimimi.i-did-not-set--mail-host-address--so-tickle-me>
	<20190403202758.GC1203@macbook41> <87zhp6rwfz.fsf@gmail.com>
	<20190407143648.GA1337@macbook41>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:60806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1hDVdY-0005aQ-KO
	for guix-devel@gnu.org; Mon, 08 Apr 2019 10:52:41 -0400
In-Reply-To: <20190407143648.GA1337@macbook41> (Efraim Flashner's message of
	"Sun, 7 Apr 2019 17:36:48 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Hello,

Efraim Flashner <efraim@flashner.co.il> skribis:

> title: Creating and using a custom Linux kernel on Guix System
> date: 2019-04-04 00:00
> author: Efraim Flashner
> tags: kernel, customization

Really nice!

> (define-public linux-libre-E2140
>   (let ((base
>           ((@@ (gnu packages linux) make-linux-libre)
>            (@@ (gnu packages linux) %linux-libre-version)
>            (@@ (gnu packages linux) %linux-libre-hash)
>            '("x86_64-linux")
>            #:extra-version "E2140"
>            #:patches (@@ (gnu packages linux) %linux-libre-5.0-patches))))

Could we make all =E2=80=98make-linux-libre=E2=80=99 public to avoid the @@=
 there?
Otherwise it=E2=80=99s a bit scary, and not something we could recommend si=
nce
we=E2=80=99re accessing private variables.

As for %linux-libre-{version,hash}, what about simply doing:

  (package-version linux-libre)

and:

  (origin-sha256 (package-source linux-libre))

Likewise for the patches:

  (origin-patches (package-source linux-libre))

With this detail fixed, I=E2=80=99m all for publishing it!

Thanks for taking the time to write this!

Ludo=E2=80=99.