all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#35804] [PATCH] libnotify didn't have propagated-inputs
@ 2019-05-19 23:23 Uko Kokņevičs
  2019-05-21 15:29 ` bug#35804: " Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Uko Kokņevičs @ 2019-05-19 23:23 UTC (permalink / raw)
  To: 35804

libnotify doesn't propagate other needed libraries for linking against
it resulting in pkg-config errors like

> Package gdk-pixbuf-2.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `gdk-pixbuf-2.0.pc'
> to the PKG_CONFIG_PATH environment variable

The following patch should fix that.


From 4cb942cd6b5389c29fa80d9af8442c3fa364406f Mon Sep 17 00:00:00 2001
From: Uko Koknevics <perkontevs@gmail.com>
Date: Mon, 20 May 2019 01:49:05 +0300
Subject: [PATCH] Added propagated-inputs to libnotify

---
 gnu/packages/gnome.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9070673..9c0cce9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1108,10 +1108,11 @@ configuring CUPS.")
        (base32
         "017wgq9n00hx39n0hm784zn18hl721hbaijda868cm96bcqwxd4w"))))
     (build-system gnu-build-system)
-    (inputs
+    (propagated-inputs
      `(("gdk-pixbuf" ,gdk-pixbuf)
-       ("glib" ,glib)
-       ("gtk+" ,gtk+)
+       ("glib" ,glib)))
+    (inputs
+     `(("gtk+" ,gtk+)
        ("libpng" ,libpng)))
     (native-inputs
       `(("pkg-config" ,pkg-config)
--
2.21.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#35804: [PATCH] libnotify didn't have propagated-inputs
  2019-05-19 23:23 [bug#35804] [PATCH] libnotify didn't have propagated-inputs Uko Kokņevičs
@ 2019-05-21 15:29 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2019-05-21 15:29 UTC (permalink / raw)
  To: Uko Kokņevičs, 35804-done

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi Uko,

Uko Kokņevičs <perkontevs@gmail.com> writes:

> libnotify doesn't propagate other needed libraries for linking against
> it resulting in pkg-config errors like
>
>> Package gdk-pixbuf-2.0 was not found in the pkg-config search path.
>> Perhaps you should add the directory containing `gdk-pixbuf-2.0.pc'
>> to the PKG_CONFIG_PATH environment variable
>
> The following patch should fix that.

Thank you!  I added a commit message that follows our convention, and
left a comment in the code explaining why these have to be propagated.

Pushed as 7ef08efa21900e6e43415b9f9db0e51a04e17fa5.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-21 15:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-19 23:23 [bug#35804] [PATCH] libnotify didn't have propagated-inputs Uko Kokņevičs
2019-05-21 15:29 ` bug#35804: " Marius Bakke

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.