From: Ricardo Wurmus <rekado@elephly.net>
To: Robert Vollmert <rob@vllmrt.net>
Cc: guix-devel@gnu.org
Subject: Re: on indentation
Date: Sat, 15 Jun 2019 14:15:56 +0200 [thread overview]
Message-ID: <87zhmjoxhf.fsf@elephly.net> (raw)
In-Reply-To: <C02D484F-5372-49A8-8A2B-2F4A8A4ACBFC@vllmrt.net>
Robert Vollmert <rob@vllmrt.net> writes:
> [ missed the list cc previously ]
>
>> On 14. Jun 2019, at 21:59, Ricardo Wurmus <rekado@elephly.net> wrote:
>>> * I can run etc/indent-code.el by hand from the guix source
>>> repo, but it would be much nicer to have it available as a
>>> regular executable.
>>
>> I would not package it. Isn’t it already usable as an executable? It
>> is a regular script after all.
>
> Well here it starts with #!/usr/bin/emacs --script. And guix environment guix
> doesn’t provide emacs. It felt like the right way around that would be to
> package it, but perhaps adding emacs to the environment and change
> the shebang to /usr/bin/env emacs would be a good change then?
The shebang is a placeholder. When you run the configure script the
placeholder is replaced with whatever “emacs” was detected.
>> Some existing code, however, may predate our indentation refinements,
>> and yet other parts may have been overlooked. When we touch those
>> sections anyway we may also adjust the indentation, but making purely
>> cosmetic commits is discouraged.
>
> I’m curious, why is that discouraged? In my experience for this kind of
> formatting issue, the best approach is to get it over with once and for all
> and enforce the standards from that point.
It makes for bad git logs and limits the usefulness of “git blame”.
--
Ricardo
prev parent reply other threads:[~2019-06-15 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 16:41 on indentation Robert Vollmert
2019-06-14 19:59 ` Ricardo Wurmus
2019-06-15 11:23 ` Robert Vollmert
2019-06-15 12:15 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhmjoxhf.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=rob@vllmrt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.