From: "Ludovic Courtès" <ludo@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 36607@debbugs.gnu.org
Subject: [bug#36607] [PATCH 1/2] gnu: Add libimagequant.
Date: Sat, 13 Jul 2019 14:52:42 +0200 [thread overview]
Message-ID: <87zhli85b9.fsf@gnu.org> (raw)
In-Reply-To: <20190711203911.8139-2-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Thu, 11 Jul 2019 22:39:10 +0200")
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * gnu/packages/image.scm (libimagequant): New variable.
> +(define-public libimagequant
> + (package
> + (name "libimagequant")
^
Nitpick: fields should be one column further to the right. (Maybe just
run ./etc/indent-code.el.)
> + (home-page "https://pngquant.org/lib/")
> + (synopsis "Image palette quantization library")
> + (description "Small, portable C library for high-quality conversion of RGBA
> +images to 8-bit indexed-color (palette) images.")
Please write a full sentence (or two :-)).
> + (license license:gpl3)))
It should be ‘gpl3+’ per ‘COPYRIGHT’.
OK to push with these changes, thanks!
Ludo’.
next prev parent reply other threads:[~2019-07-13 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 20:29 [bug#36607] [PATCH 0/2] Add pngquant and libimagequant required by it Hartmut Goebel
2019-07-11 20:39 ` Hartmut Goebel
2019-07-11 20:39 ` [bug#36607] [PATCH 1/2] gnu: Add libimagequant Hartmut Goebel
2019-07-13 12:52 ` Ludovic Courtès [this message]
2019-07-13 18:06 ` bug#36607: " Hartmut Goebel
2019-07-11 20:39 ` [bug#36607] [PATCH 2/2] gnu: Add pngquant Hartmut Goebel
2019-07-13 12:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhli85b9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=36607@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.