all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
@ 2019-10-28 15:34 Clément Lassieur
  2019-10-28 15:43 ` Clément Lassieur
  2019-10-29  7:43 ` Mathieu Othacehe
  0 siblings, 2 replies; 5+ messages in thread
From: Clément Lassieur @ 2019-10-28 15:34 UTC (permalink / raw)
  To: 37962

Because it is buggy and unnecessary.  See
<https://github.com/emacs-evil/evil/issues/1074>.

* gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
emacs-undo-tree and emacs-goto-chg.
---
 gnu/packages/emacs-xyz.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 688206452e..ba8ece1e22 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
         (base32
          "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
     (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-undo-tree" ,emacs-undo-tree)
-       ("emacs-goto-chg" ,emacs-goto-chg)))
     (home-page "https://github.com/emacs-evil/evil")
     (synopsis "Extensible Vi layer for Emacs")
     (description
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
  2019-10-28 15:34 [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency Clément Lassieur
@ 2019-10-28 15:43 ` Clément Lassieur
  2019-10-28 15:50   ` Clément Lassieur
  2019-10-29  7:43 ` Mathieu Othacehe
  1 sibling, 1 reply; 5+ messages in thread
From: Clément Lassieur @ 2019-10-28 15:43 UTC (permalink / raw)
  To: 37962

The idea is that if people need it, they can install it and it'll just
work, but I personnaly don't want 'u' to be bound to undo-tree because
it has unfixed bugs that can lead to data loss[1].

'r' won't work anymore, but C-/ can be used instead[2].

Cheers,
Clément

[1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
[2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
  2019-10-28 15:43 ` Clément Lassieur
@ 2019-10-28 15:50   ` Clément Lassieur
  0 siblings, 0 replies; 5+ messages in thread
From: Clément Lassieur @ 2019-10-28 15:50 UTC (permalink / raw)
  To: 37962

clement@lassieur.org (Clément Lassieur) writes:

> The idea is that if people need it, they can install it and it'll just
> work, but I personnaly don't want 'u' to be bound to undo-tree because
> it has unfixed bugs that can lead to data loss[1].
>
> 'r' won't work anymore, but C-/ can be used instead[2].

I meant C-r (undo-tree-redo).

>
> Cheers,
> Clément
>
> [1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097
> [2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
  2019-10-28 15:34 [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency Clément Lassieur
  2019-10-28 15:43 ` Clément Lassieur
@ 2019-10-29  7:43 ` Mathieu Othacehe
  2019-10-29 10:07   ` Clément Lassieur
  1 sibling, 1 reply; 5+ messages in thread
From: Mathieu Othacehe @ 2019-10-29  7:43 UTC (permalink / raw)
  To: 37962


Hello Clément,

This LGTM!

Thanks,

Mathieu

Clément Lassieur writes:

> Because it is buggy and unnecessary.  See
> <https://github.com/emacs-evil/evil/issues/1074>.
>
> * gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove
> emacs-undo-tree and emacs-goto-chg.
> ---
>  gnu/packages/emacs-xyz.scm | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 688206452e..ba8ece1e22 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")
>          (base32
>           "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))
>      (build-system emacs-build-system)
> -    (propagated-inputs
> -     `(("emacs-undo-tree" ,emacs-undo-tree)
> -       ("emacs-goto-chg" ,emacs-goto-chg)))
>      (home-page "https://github.com/emacs-evil/evil")
>      (synopsis "Extensible Vi layer for Emacs")
>      (description

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency.
  2019-10-29  7:43 ` Mathieu Othacehe
@ 2019-10-29 10:07   ` Clément Lassieur
  0 siblings, 0 replies; 5+ messages in thread
From: Clément Lassieur @ 2019-10-29 10:07 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 37962

thanks!  Pushed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-10-29 10:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-28 15:34 [bug#37962] [PATCH] gnu: emacs-evil: Remove undo-tree dependency Clément Lassieur
2019-10-28 15:43 ` Clément Lassieur
2019-10-28 15:50   ` Clément Lassieur
2019-10-29  7:43 ` Mathieu Othacehe
2019-10-29 10:07   ` Clément Lassieur

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.