From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH 1/2] Support publishing build events Date: Thu, 28 Nov 2019 18:48:23 +0000 Message-ID: <87zhgfet1k.fsf@cbaines.net> References: <8736fjqbrd.fsf@cbaines.net> <20191028081026.25988-1-mail@cbaines.net> <87bltbts9h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaP1z-0006xF-Ul for guix-devel@gnu.org; Thu, 28 Nov 2019 14:00:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaOq6-0001d0-KD for guix-devel@gnu.org; Thu, 28 Nov 2019 13:48:31 -0500 In-reply-to: <87bltbts9h.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris, > > Christopher Baines skribis: > >> --- >> Makefile.am | 8 +- >> bin/cuirass-send-events.in | 90 +++++++++++++++++++++++ >> src/cuirass/base.scm | 9 ++- >> src/cuirass/database.scm | 142 +++++++++++++++++++++++++++++++++--- >> src/cuirass/http.scm | 24 ++++++ >> src/cuirass/send-events.scm | 69 ++++++++++++++++++ >> src/schema.sql | 12 +++ >> src/sql/upgrade-5.sql | 15 ++++ >> 8 files changed, 356 insertions(+), 13 deletions(-) >> create mode 100644 bin/cuirass-send-events.in >> create mode 100644 src/cuirass/send-events.scm >> create mode 100644 src/sql/upgrade-5.sql > > Sorry for the delay. It LGTM, thank you! > > Please add a commit log :-), and let us know when you=E2=80=99d like to t= est > with the instance on berlin or that on bayfront. Following up on this again, I've now sent a couple of updated patches. Not much about the code has changed, I fixed a typo, added better error handling to sending events, and added changelog entries to the commit messages. I have done more testing though, and also added more support for receiving events to the Guix Data Service (mostly in this commit [1]). 1: https://git.savannah.gnu.org/cgit/guix/data-service.git/commit/?id=3D566= 3235048b7341b378634d083eaae9f13580e07 In terms of the code, the Guix Data Service is now capable of handling Cuirass sending it events, and I've been testing this locally using the random Cuirass example. I'm not sure whether it's worth trying this out on bayfront prior to merging the changes, or merging them and then trying it out on bayfront, but either way, at the moment there's no rush, as the Guix Data Service is down at the moment due to hardware issues. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl3gFndfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcCkg/9GaZaJIXBdiAL0yYAuXP5bMpsweB+j5jjCyGysZLYwweSp9LghDvR1Dzu nfTzRr/dErYj/fH50/zKpXwz2vMw8bl7oCK9MktI9zie0PAGSdNOF+HTejMpa/wj JptRO1IUAjFNT9WSqcQ4fWqhnV8O6MGC7Ksu6UKQCQVpiIbg9shPukUpGKQaBKlr GI2nkFiAntY+JuSPElfFQqXXi8bnV8hPZeN+MKXl3DX2En/sz7eT/5vwNChpnBfJ fwv71RTV3jZqeNps2IIFqVsp8rUSsFAYpVqjkNoa7tWmnedcEbx1cSpanPOJc585 8zKg+JIqC+jytQhrBVFYHfgw8Vc6MbnCHb68eqM2kOIrwrg4kx4pJzu6L97WbJBh 8w964afu5FJKJVZAyfr2bbiRC1f+uTxx/Pqk55P/+ioSz56Fg4kN1pkq0+tcxCht rY1/YVKPhzdi0a4BEhGQ2lKOm7l9MEXrcix70riO49FgpIhPfDA6dGyd4K4vzz5e NpfuODlU809Rm2apu12K8Yo1QzZH2/7mQHt+zkIA7aDXAbO8/izEqS3ui1ZjaC+K fQJVL422vWVc019na7OU0ZsvMSkKgRKhmU6XXZx+DU6ynmmP3J/NsFP3LFGzl7c9 pQBuIgPA00wP9BXY8z/Fpn1Svwe1LSWZoJ5wZ9r9CC1l2gLYC1I= =F7eT -----END PGP SIGNATURE----- --=-=-=--