From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56380)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFm4B-00082i-Ce
 for guix-patches@gnu.org; Sat, 21 Mar 2020 17:54:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFm4A-0004Yz-E0
 for guix-patches@gnu.org; Sat, 21 Mar 2020 17:54:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42354)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFm4A-0004Yp-AL
 for guix-patches@gnu.org; Sat, 21 Mar 2020 17:54:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFm4A-0007qm-9N
 for guix-patches@gnu.org; Sat, 21 Mar 2020 17:54:02 -0400
Subject: [bug#40114] [PATCH] services: Add fontconfig-file-system-service.
Resent-Message-ID: <handler.40114.B40114.158482764030168@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200318104626.20381-1-efraim@flashner.co.il>
Date: Sat, 21 Mar 2020 22:53:50 +0100
In-Reply-To: <20200318104626.20381-1-efraim@flashner.co.il> (Efraim Flashner's
 message of "Wed, 18 Mar 2020 12:46:26 +0200")
Message-ID: <87zhc9wf0x.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 40114@debbugs.gnu.org

Hello!

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/services/desktop.scm (%fontconfig-file-system,
> fontconfig-file-system-service): New variables.
> (%desktop-services): Add fontconfig-file-system-service.

[...]

> +(define %fontconfig-file-system
> +  (file-system
> +    (device "none")
> +    (mount-point "/var/cache/fontconfig")
> +    (type "tmpfs")
> +    (flags '(read-only))
> +    (check? #f)))
> +
> +;; The global fontconfig directory is unused in Guix and has been
> +;; known to cause problems so we mount it read-only.

What about something like:

  ;; The global fontconfig cache directory can sometimes contain stale
  ;; entries, possibly referencing fonts that have been GC=E2=80=99d, so mo=
unt
  ;; it read-only.

I think that=E2=80=99s a correct summary?  Perhaps we could link to past
discussions if we have one.

Otherwise LGTM, thank you!

Ludo=E2=80=99.