From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: bug#40528: 'guix lint' does not check whether propagated-inputs should be native Date: Fri, 10 Apr 2020 09:51:52 +0100 Message-ID: <87zhbj7mfr.fsf@cbaines.net> References: <87h7xsjqt2.fsf@devup.no> <20200409213131.GX1518@E5400> <87eeswjpz9.fsf@devup.no> <20200409215010.GY1518@E5400> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45387) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMpON-0001Jh-2G for bug-guix@gnu.org; Fri, 10 Apr 2020 04:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMpOM-0004UI-0V for bug-guix@gnu.org; Fri, 10 Apr 2020 04:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMpOL-0004UD-T7 for bug-guix@gnu.org; Fri, 10 Apr 2020 04:52:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jMpOL-00047L-RH for bug-guix@gnu.org; Fri, 10 Apr 2020 04:52:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <20200409215010.GY1518@E5400> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Marius Bakke , 40528-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Efraim Flashner writes: > On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote: >> Efraim Flashner writes: >> >> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: >> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of >> >> a package, not propagated-inputs. >> > >> > The attached patch should add the propagated inputs to the list of >> > inputs to check. Do we want to start telling it to ignore some of them? >> >> Wow, that was incredibly fast! >> >> > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' should probably be a native input >> >> I'm inclined to leave it. I think many of these plugin packages should >> not be propagating the package that they plug into anyway. >> >> LGTM! > > OK, patch pushed. Looks like it's working :) [1] 1: http://data.guix.gnu.org/compare?base_commit=960abd585940c33744040c79e2a37e588d36e589&target_commit=d95252baf97adb261dd823d4e7a74a7522815c1c --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6QM6hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfQQQ/+Pl0enu20EzmHkKEx3y5pY3j7i/bg0B2nPriD1tGwniw0joC5kqwWwVPB R2kXamxdGRE+i/U1Vt+hMFWY/AJ+MHFR8wsG0p1O3Z9XzVGx1q3sy501F+HHcJa6 8kBYKrHS5F1aVCBgwX4K+Vj5P8pBKkrA9HGsVlSgneohJ/hRZNB1Fev7vE1/6u2v XkXbid6OAyZlXM9JR/rPkLcPWgmS9TdmYaK9Z1QxS4iNYoBM8/btvlIZ0RxHy6BJ 1/ffpcSTUG3sS8F1X6W2wqsY74j6bhtCOAeD6jMlwubXZ+ikN5rtRRvJoZvWBkep wIVsPUqrbg3+NaVPwq5javXFrkkw3EE+8s/C9psmmjljTA5lCNcCBtVzuiVa6U8K k7lHu9djhKvmMdoxi9AOZUOYiF7mNKWCOiQFHFbsV4fl5O1hjTw2T9OM5zBeiRSD 1By8Q43GK4RuiVu1qp/tDVf0fGQQVT/+hB41S+kiZhV74tevSg5MyNJ7WRm/dvtT EXpWPGqBnKcccFcp7FF7dWCLOOrWE1cihAh7AYSpX9zdxjJ8QCFpzfF5MZw+uxOH hx/G3HrrjU0Xw7cL827ly6m7Qsf15YT+X4UpBIKS4FOCvAfJzjoFzjpXte0Q28l9 XUSga+j6JTsvi5poiJgLCfzmaYpAUQRb3yYAcMGvdfhEhDZzX/U= =YQRZ -----END PGP SIGNATURE----- --=-=-=--