From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43084) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jR1O3-0007q9-D2 for guix-patches@gnu.org; Tue, 21 Apr 2020 18:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jR1O2-0005GF-Mh for guix-patches@gnu.org; Tue, 21 Apr 2020 18:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39354) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jR1O2-0005Fd-Ai for guix-patches@gnu.org; Tue, 21 Apr 2020 18:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jR1O1-0006wD-Vz for guix-patches@gnu.org; Tue, 21 Apr 2020 18:29:02 -0400 Subject: [bug#40752] gnu: Add eject. Resent-Message-ID: References: <20200421162206.527fd8c8.raghavgururajan@disroot.org> In-reply-to: <20200421162206.527fd8c8.raghavgururajan@disroot.org> Date: Wed, 22 Apr 2020 00:28:30 +0200 Message-ID: <87zhb4wk1d.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 40752@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Raghav, Thanks for the patch! Amazing that this wasn't in Guix yet. Even=20 more amazing that I didn't package it. Raghav Gururajan =E5=86=99=E9=81=93=EF=BC=9A +(define-public eject + (package + (name "eject") + (version "2019.08.22") You've been around long enough to know how we package git releases=20 :-) Certainly not like this. More like ;; Comment explaining why we use a git snapshot. (let ((commit "12a22e=E2=80=A6") (revision "0")) (package =E2=80=A6 (version (git version "2.1.=E2=80=A6" revision commit)) please. Upstream[0 ]says there's a 2.1.6 version, but it may exist nowhere=20 but in the author's mind. If you do find a tarball, tag, or=20 corresponding commit, use it, or explain in a comment why 12a22e=20 is better. + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://git.code.sf.net/p/eject/git") + (commit "12a22e"))) Please don't abbreviate commits like this. + (file-name (git-file-name name version)) Yay! + (sha256 + (base32=20 "1dxj0zn32l8k16j5innh8y4snambx1b702ny37114drddqcqac6h")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; No target Write =E2=80=98; no test suite=E2=80=99 instead, which is to be expected fr= om a=20 package like this. =E2=80=98No target=E2=80=99 makes it sound like who knows, there might be t= ests,=20 but there's no make rule to run them, so we don't. Not a good=20 look. + #:make-flags + (list Hm? Eh? Oh=E2=80=A6 Please insert a comment here: ;; ./configure respects --prefix=3D; the handwritten=20 po/Makefile doesn't. + (string-append "PREFIX=3D" (assoc-ref %outputs "out"))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("gettext" ,gettext-minimal))) + (inputs + `(("lvm2" ,lvm2) + ("sg3-utils" ,sg3-utils))) + (synopsis "Utility for Removable Media") =E2=80=A6is too vague. And this is worse: + (description "Eject allows removable media (typically a=20 CD-ROM, floppy disk, +tape, or JAZ or ZIP disk) to be ejected under software control.=20 The command can +also control some multi-disc CD-ROM changers, the auto-eject=20 feature supported +by some devices, and close the disc tray of some CD-ROM=20 drives. ") I know this is upstream's handiwork; not yours, but crikey. Always feel free to edit the hell out of these texts. =E2=80=98Software=20 Foo allows gizmos to be frobbed under software control=E2=80=99? =E2=86=92 = =E2=80=98Foo=20 frobs gizmos=E2=80=99. Done. A quick attempt with some inspiration from Debian: (synopsis "Eject and safely disconnect removable media") (description "This little program will eject CD-ROMs and other ejectable=20 removable media. It can also set the auto-eject feature, close the tray of some=20 CD-ROM drives, and select the active disc in supported multi-disc changers. You can also use @command{eject} to properly disconnect external=20 mass-storage devices like mobile phones, digital cameras, or portable music=20 players.") + (home-page "http://eject.sourceforge.net") + (license license:gpl2+))) + I wasn't able to apply & test this patch; I guess =E2=80=98udevil=E2=80=99 = is=20 still under review. I don't have time to review it as well. Please: try to add new packages in alphabetical order, NOT blindly=20 to the beginning or end of files. For once, this has nothing=20 (well, less) to do with my obsession for ordnung. It makes=20 annoying issues like this less likely. It doesn't matter that most package .scm files are an unordered=20 mess: if you'd added eject near the beginning and udevil near the=20 end, the two unrelated packages wouldn't conflict. Kind regards, T G-R [0]: https://sourceforge.net/p/eject/git/ci/master/tree/NEWS --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXp9zjgAKCRANsP+IT1Vt eUdzAQCsY3wEcy5Wwp+VBVbDNRO1WPxYlVgb4kiLHojKIq3MFAD9EHeMA+3UW3oN qVfabUaMLmd8q4vFClbgSyhCvvtqtwo= =B1RC -----END PGP SIGNATURE----- --=-=-=--