From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AANfOYdjwV5+IQAA0tVLHw (envelope-from ) for ; Sun, 17 May 2020 16:17:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MFxSNYdjwV4VXAAAB5/wlQ (envelope-from ) for ; Sun, 17 May 2020 16:17:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F3BA9404E1 for ; Sun, 17 May 2020 16:17:11 +0000 (UTC) Received: from localhost ([::1]:51246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaLyP-0004qB-C4 for larch@yhetil.org; Sun, 17 May 2020 12:17:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaLyI-0004pd-SU for guix-patches@gnu.org; Sun, 17 May 2020 12:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaLyI-0005mC-JX for guix-patches@gnu.org; Sun, 17 May 2020 12:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaLyI-0006Fr-Dw for guix-patches@gnu.org; Sun, 17 May 2020 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#37305] Allow booting from a Btrfs subvolume [review part 2] Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 May 2020 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37305 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Neidhardt Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 37305@debbugs.gnu.org Received: via spool by 37305-submit@debbugs.gnu.org id=B37305.158973218323981 (code B ref 37305); Sun, 17 May 2020 16:17:02 +0000 Received: (at 37305) by debbugs.gnu.org; 17 May 2020 16:16:23 +0000 Received: from localhost ([127.0.0.1]:44442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaLxf-0006Ej-74 for submit@debbugs.gnu.org; Sun, 17 May 2020 12:16:23 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:43856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaLxd-0006EW-Rn for 37305@debbugs.gnu.org; Sun, 17 May 2020 12:16:22 -0400 Received: by mail-qt1-f169.google.com with SMTP id o19so6141884qtr.10 for <37305@debbugs.gnu.org>; Sun, 17 May 2020 09:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7eWNzdu7Eu/kVUz0I3OS3BnhUovicoSbOev2viP7O48=; b=SgRhmwuz54/5rtp60AMEzj0a0VlX044gC1wLXcEaUGaRVxMP2ZOBCdWbAixOwmPUzZ k6y9REGy/y5iSsoEWAbQwqjerTssSUqFnQX1jQzRWrMjAHVpRmaPpvg0lMaVM1G+izai ObVhkB38GAHtZ3jC0RvkVgH3rWEyjohRT7DJtw3ODzrIXtpi4i24zzAJgnHPtXWveopq oeM5E3jawQa7hp7jEW/t4VXuMR/ZR5aK1FAwmVkRQuIFtlmspXzPFmjWZfFxLyaB9KNW 4xe1WvGqQh1BoeeMqBOFmAwOMs+VoUmpruiV+QdDc99XtKy7b9m95H4RfU8HyvHg8cUq G7xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7eWNzdu7Eu/kVUz0I3OS3BnhUovicoSbOev2viP7O48=; b=XpyX2+1bJQcOUbyxUKhWLVoLsBEiGvOG2fLN2Z8hUnBEaunTtzQbsWanp4mvAfQxIE rgpok3RgxF5R9J73hdEIRaAUfOwIYuNdyAFNt3Tvuk9gE5qpkvw+9xVggI9jBAYnuL6N njT6XflNhOxASfNNPF7JT3yEufh7zGyowzPkemI48svf7HaKdAnU/OQk4S3JpQuEzKse rAe+XU8vh8Qi8IxKuEYq0WLW7m16mqjM1x9RgNLLYlJ7TJmfcOYIL0HME/8EOHzvUqPZ KHzb8/3z9EWvRzA+aaDKlWu60kUfAEnWB9PwMo5Mi7aajSgrANV16iNnfU5t9DDafKyz Tk/Q== X-Gm-Message-State: AOAM530tmTamjPotyN6TxlAialClXBOCbYYpESdexoP0WIo0VP5zlrAm YVz3w5IuXcuAKfjX3idBtQB6OhF/3ho= X-Google-Smtp-Source: ABdhPJwCjmTl7bdmRzPZOIt+r+O15SuX8McFJECqbtf2XK71a6JupTwQrTIAm1h5TF6AeBHo9k6T8A== X-Received: by 2002:ac8:3733:: with SMTP id o48mr12570583qtb.149.1589732176338; Sun, 17 May 2020 09:16:16 -0700 (PDT) Received: from hurd (dsl-236-125-8.b2b2c.ca. [207.236.125.8]) by smtp.gmail.com with ESMTPSA id n5sm6123697qke.124.2020.05.17.09.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2020 09:16:16 -0700 (PDT) From: Maxim Cournoyer References: <875zg2xtsb.fsf@gmail.com> <87lfoxbn2e.fsf@gnu.org> <87v9n1pts1.fsf@raisin.i-did-not-set--mail-host-address--so-tickle-me> <87lflqhd4y.fsf@ambrevar.xyz> Date: Sun, 17 May 2020 12:16:07 -0400 In-Reply-To: <87lflqhd4y.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Sun, 17 May 2020 16:03:41 +0200") Message-ID: <87zha6a660.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=SgRhmwuz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: sTo6I/y4qNYs Hello Pierre! Pierre Neidhardt writes: > Hi Maxim! > > maxim.cournoyer@gmail.com writes: > >> +@lisp >> +(file-system >> + (device (file-system-label "btrfs-pool-1")) >> + (mount-point "/gnu/store") >> + (type "btrfs") >> + (options "subvol=root-snapshots/root-current/guix-store" >> + ("compress" . "zstd"))) >> +@end lisp > > > Is this ("compress" . "zstd") intentional? It does not match the first example. Good catch! This pair syntax was removed, based on feedback from previous reviews. It can still be used with the helper procedures, but not directly like that. It should be fixed in the patch series I just sent in the previous email. Thank you, Maxim