From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UNEyGpAzpF9rSQAA0tVLHw (envelope-from ) for ; Thu, 05 Nov 2020 17:17:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YIkeFpAzpF/XHgAAbx9fmQ (envelope-from ) for ; Thu, 05 Nov 2020 17:17:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DF4894011C for ; Thu, 5 Nov 2020 17:17:04 +0000 (UTC) Received: from localhost ([::1]:50012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaisg-00052j-Ut for larch@yhetil.org; Thu, 05 Nov 2020 12:17:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaijy-0004h3-3j for guix-patches@gnu.org; Thu, 05 Nov 2020 12:08:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaijx-0007W3-Ps for guix-patches@gnu.org; Thu, 05 Nov 2020 12:08:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kaijx-0000Tk-Ln for guix-patches@gnu.org; Thu, 05 Nov 2020 12:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44470] [PATCH] gnu: Added emacs-solidity. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Nov 2020 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44470 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze Cc: 44470@debbugs.gnu.org Received: via spool by 44470-submit@debbugs.gnu.org id=B44470.16045960761830 (code B ref 44470); Thu, 05 Nov 2020 17:08:01 +0000 Received: (at 44470) by debbugs.gnu.org; 5 Nov 2020 17:07:56 +0000 Received: from localhost ([127.0.0.1]:54000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaijs-0000TQ-12 for submit@debbugs.gnu.org; Thu, 05 Nov 2020 12:07:56 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:34937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaijp-0000TB-Jf for 44470@debbugs.gnu.org; Thu, 05 Nov 2020 12:07:55 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 600501C0008; Thu, 5 Nov 2020 17:07:45 +0000 (UTC) From: Nicolas Goaziou References: <20201105152052.6017-1-mjbecze@riseup.net> Date: Thu, 05 Nov 2020 18:07:44 +0100 In-Reply-To: <20201105152052.6017-1-mjbecze@riseup.net> (Martin Becze's message of "Thu, 5 Nov 2020 09:20:52 -0600") Message-ID: <87zh3vlokf.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: MRIVIIfQkyB6 Hello, Martin Becze writes: > * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable. Thank you. > + ;; No release. > + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e")) Is there any reason to use this particular instead of e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10" release? If so, please mention it in the comment above. > + (package > + (name "emacs-solidity") > + (version (git-version "0.1.10" "1" commit)) If we use the commit above, `version' can simply become "0.1.10". > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ethereum/emacs-solidity") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq")))) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-company" ,emacs-company) > + ("emacs-flycheck" ,emacs-flycheck))) > + (home-page "https://github.com/ethereum/emacs-solidity") > + (synopsis "Major mode for writing Solidity code") > + (description "A simple language mode for the Solidity language. It is a > +constant work in progress as the language itself also progresses.") The first sentence should be "complete", i.e., with a subject and a verb. Could you send an updated patch? Regards, -- Nicolas Goaziou