From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iJp1CENU11/rcwAA0tVLHw (envelope-from ) for ; Mon, 14 Dec 2020 12:02:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id /XxOBENU119UOgAA1q6Kng (envelope-from ) for ; Mon, 14 Dec 2020 12:02:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C44479403EB for ; Mon, 14 Dec 2020 12:02:10 +0000 (UTC) Received: from localhost ([::1]:46744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kol7X-0000ys-Jn for larch@yhetil.org; Mon, 14 Dec 2020 05:30:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kol7C-0000yT-6U for bug-guix@gnu.org; Mon, 14 Dec 2020 05:30:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kol7B-0001oh-VA for bug-guix@gnu.org; Mon, 14 Dec 2020 05:30:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kol7B-0007Sy-QX for bug-guix@gnu.org; Mon, 14 Dec 2020 05:30:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45187: git download defaults to origin/master Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 14 Dec 2020 10:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45187 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Kyle Meyer Received: via spool by 45187-submit@debbugs.gnu.org id=B45187.160794174728597 (code B ref 45187); Mon, 14 Dec 2020 10:30:01 +0000 Received: (at 45187) by debbugs.gnu.org; 14 Dec 2020 10:29:07 +0000 Received: from localhost ([127.0.0.1]:51287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kol6I-0007RB-Tj for submit@debbugs.gnu.org; Mon, 14 Dec 2020 05:29:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kol6H-0007Qh-Hn for 45187@debbugs.gnu.org; Mon, 14 Dec 2020 05:29:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49755) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kol6B-0001j0-Sz; Mon, 14 Dec 2020 05:28:59 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39942 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kol6A-0005vR-5Y; Mon, 14 Dec 2020 05:28:59 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <878sa4vyxb.fsf@elephly.net> <87v9d8dk0r.fsf@kyleam.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Frimaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 14 Dec 2020 11:28:56 +0100 In-Reply-To: <87v9d8dk0r.fsf@kyleam.com> (Kyle Meyer's message of "Fri, 11 Dec 2020 23:02:02 GMT") Message-ID: <87zh2gu1ef.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45187@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: C44479403EB X-Spam-Score: -2.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: +M3roNmGp/2k Hi, Kyle Meyer skribis: > diff --git a/guix/git.scm b/guix/git.scm > index ca77b9f54b..7320c0d6c8 100644 > --- a/guix/git.scm > +++ b/guix/git.scm > @@ -207,6 +207,9 @@ (define (resolve-reference repository ref) > (let ((oid (reference-target > (branch-lookup repository branch BRANCH-REMOTE)))) > (object-lookup repository oid))) > + (('symref . symref) > + (let ((oid (reference-name->oid repository symref))) > + (object-lookup repository oid))) > (('commit . commit) > (let ((len (string-length commit))) > ;; 'object-lookup-prefix' appeared in Guile-Git in Mar. 2018, s= o we > @@ -320,7 +323,7 @@ (define (reference-available? repository ref) >=20=20 > (define* (update-cached-checkout url > #:key > - (ref '(branch . "master")) > + (ref '(symref . "refs/remotes/origin/HE= AD")) > recursive? > (check-out? #t) > starting-commit > @@ -395,7 +398,7 @@ (define* (latest-repository-commit store url > (log-port (%make-void-port "w")) > (cache-directory > (%repository-cache-directory)) > - (ref '(branch . "master"))) > + (ref '(symref . "refs/remotes/origin/= HEAD"))) Do we really need to add =E2=80=9Cremotes/origin=E2=80=9D in there? Or is = there a way to just say HEAD and later specify that we=E2=80=99re talking about the rem= ote head, as is done fro branches? We also need to change the defaults in & co., like Marius di= d. Thanks, Ludo=E2=80=99.