From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ZZ3DEvXBGmC7HgAA0tVLHw (envelope-from ) for ; Wed, 03 Feb 2021 15:32:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6A1RDvXBGmC7NQAAB5/wlQ (envelope-from ) for ; Wed, 03 Feb 2021 15:32:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73D52940969 for ; Wed, 3 Feb 2021 15:32:04 +0000 (UTC) Received: from localhost ([::1]:56388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7K8R-0000nt-Fe for larch@yhetil.org; Wed, 03 Feb 2021 10:32:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7K6X-0007qI-KX for guix-patches@gnu.org; Wed, 03 Feb 2021 10:30:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7K6U-0005hw-Qx for guix-patches@gnu.org; Wed, 03 Feb 2021 10:30:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7K6U-0003r4-N8 for guix-patches@gnu.org; Wed, 03 Feb 2021 10:30:02 -0500 Subject: bug#46095: [PATCH] gnu: Add mingw-w64-tools. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 03 Feb 2021 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 46095 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Mail-Followup-To: 46095@debbugs.gnu.org, maxim.cournoyer@gmail.com, lle-bout@zaclys.net Received: via spool by 46095-done@debbugs.gnu.org id=D46095.161236617114720 (code D ref 46095); Wed, 03 Feb 2021 15:30:02 +0000 Received: (at 46095-done) by debbugs.gnu.org; 3 Feb 2021 15:29:31 +0000 Received: from localhost ([127.0.0.1]:38623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7K5y-0003pL-F5 for submit@debbugs.gnu.org; Wed, 03 Feb 2021 10:29:30 -0500 Received: from mail-qk1-f179.google.com ([209.85.222.179]:46288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7K5x-0003p4-EW for 46095-done@debbugs.gnu.org; Wed, 03 Feb 2021 10:29:29 -0500 Received: by mail-qk1-f179.google.com with SMTP id a7so23682717qkb.13 for <46095-done@debbugs.gnu.org>; Wed, 03 Feb 2021 07:29:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=xvpomW9mMkJSlyGi+TS2pgoM1QrdotJd7EzIajItSvs=; b=hYIvIhj2XfG2cGRtxzoID2RLFJQijkqAafpExIXztytVgJkB+xxqs5bkM01qnt4O2s u2NDo2meW6/O50CedaqXrFRzQssBO55gRPK4XQPD9m0MbccHO3N5vVfDMn2xcxmYwAj8 N3tHy5HO+Diz6tYgGkiJ+GtOk+vGQ61FI/mEjzEQK+oIaGZFLkdjlZ1Q8Kjo0DMWTnes TjdhFtv4TeijrK320rTLJyN04/T94gheVlSLqdGCeeJ5LZaFnjBOmpSBc5hEevwC9NEY bwvkb+4Jq5m7p3PR5pAzV6uaCLNNqEB640KjLwUZB13Bq6ahHmVjPg0yhycGKYIyB5kM DMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=xvpomW9mMkJSlyGi+TS2pgoM1QrdotJd7EzIajItSvs=; b=SBuPa/BxcOjLypj8LSLWOEY8gGUxWuTLhWvGGtzWdCoM7vWw6+KXxxaGw3WLtFpuVK ZxRTQX9k8W/BmpjxIfFqBP/+B77A2owSMY/iZaGNeLHdedtBl983f4v13nFdU0n2rhAd 00gzFEvW6QqhB+IuWAk7GQRE8Lry3UPwWLgIhvpIROTaZXdj6OnkUnR2dstz82ja+nNK gpb/G4TL7P14ApIPf+8fHvM4onegueCoaerbQMPDFp2MLuj7Wa2SWBm0Mr/Lls4gYH6J FAEJh7fAEawuupwWfimkb/Eb6rTD9E2jWGPrlfgCIaF1mGanaXLIVyq+EAtp6RiN7hwy S28g== X-Gm-Message-State: AOAM533n/YMUrUfVlUSLQaH/ZU3dIk7Tg47sxKJEQujGc09PYpAI24wY TWHGZ0IAITeHqjoPsillTqKA8KV5aD8= X-Google-Smtp-Source: ABdhPJx6mqVhafPcMPDLU4o7hUKuMGmd/oQyUfGOwFcpE46rPX1tmgc/ExYXX26G8xfIGjzTBjdKng== X-Received: by 2002:a37:a992:: with SMTP id s140mr3006825qke.286.1612366163859; Wed, 03 Feb 2021 07:29:23 -0800 (PST) Received: from hurd (dsl-157-110.b2b2c.ca. [66.158.157.110]) by smtp.gmail.com with ESMTPSA id o76sm1816868qke.104.2021.02.03.07.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 07:29:23 -0800 (PST) From: Maxim Cournoyer References: <20210125102135.13874-1-lle-bout@zaclys.net> <878s85pwhc.fsf@gmail.com> Date: Wed, 03 Feb 2021 10:29:22 -0500 In-Reply-To: <878s85pwhc.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 03 Feb 2021 00:10:39 -0500") Message-ID: <87zh0lnp9p.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46095-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=hYIvIhj2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 73D52940969 X-Spam-Score: -1.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: fZAnB1QxH1LU Hello, Maxim Cournoyer writes: > Hello, > > L=C3=A9o Le Bouter writes: > >> * gnu/packages/mingw.scm (mingw-w64-tools): New variable. >> --- >> gnu/packages/mingw.scm | 75 ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 75 insertions(+) >> >> diff --git a/gnu/packages/mingw.scm b/gnu/packages/mingw.scm >> index b37f6c69bd..884cb7e39f 100644 >> --- a/gnu/packages/mingw.scm >> +++ b/gnu/packages/mingw.scm >> @@ -133,3 +133,78 @@ several new APIs such as DirectX and DDK, and 64-bi= t support.") >> #:with-winpthreads? #t)) >>=20=20 >> (define-public mingw-w64 mingw-w64-i686) >> + >> +(define-public mingw-w64-tools >> + (package >> + (name "mingw-w64-tools") >> + (version "7.0.0") > > That doesn't seem to be the latest version. Is there a good reason why? > If so, please add a comment, else use the latest version. > >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "mirror://sourceforge/mingw-w64/mingw-w64/" >> + "mingw-w64-release/mingw-w64-v" version ".tar.bz2")) >> + (sha256 >> + (base32 "0a5njsa2zw2ssdz10jkb10mhrf3cb8qp9avs89zqmw4n6pzxy85a")= ))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:modules (((guix build gnu-build-system) #:prefix gnu:) >> + ,@%gnu-build-system-modules) >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'cd-gendef >> + (lambda _ (chdir "mingw-w64-tools/gendef") >> + #t)) > > It's a recent change, but ending phases by #t is no longer required. > >> + >> + (add-after 'install 'cd-genidl >> + (lambda _ (chdir "../genidl") >> + #t)) >> + (add-after 'cd-genidl 'configure-genidl >> + (assoc-ref gnu:%standard-phases 'configure)) >> + (add-after 'configure-genidl 'build-genidl >> + (assoc-ref gnu:%standard-phases 'build)) >> + (add-after 'build-genidl 'check-genidl >> + (assoc-ref gnu:%standard-phases 'check)) >> + (add-after 'check-genidl 'install-genidl >> + (assoc-ref gnu:%standard-phases 'install)) >> + >> + (add-after 'install-genidl 'cd-genlib >> + (lambda _ (chdir "../genlib") >> + #t)) >> + (add-after 'cd-genlib 'configure-genlib >> + (assoc-ref gnu:%standard-phases 'configure)) >> + (add-after 'configure-genlib 'build-genlib >> + (assoc-ref gnu:%standard-phases 'build)) >> + (add-after 'build-genlib 'check-genlib >> + (assoc-ref gnu:%standard-phases 'check)) >> + (add-after 'check-genlib 'install-genlib >> + (assoc-ref gnu:%standard-phases 'install)) >> + >> + (add-after 'install-genlib 'cd-genpeimg >> + (lambda _ (chdir "../genpeimg") >> + #t)) >> + (add-after 'cd-genpeimg 'configure-genpeimg >> + (assoc-ref gnu:%standard-phases 'configure)) >> + (add-after 'configure-genpeimg 'build-genpeimg >> + (assoc-ref gnu:%standard-phases 'build)) >> + (add-after 'build-genpeimg 'check-genpeimg >> + (assoc-ref gnu:%standard-phases 'check)) >> + (add-after 'check-genpeimg 'install-genpeimg >> + (assoc-ref gnu:%standard-phases 'install))))) >> + (home-page "https://mingw-w64.org") >> + (synopsis "Tools of Minimalist GNU for Windows") >> + (description >> + "This package provides tools of Minimalist GNU for Windows. >> + >> +Minimalist GNU for Windows (@dfn{MinGW}) is a complete software >> +development environment for creating native Microsoft Windows applicati= ons. >> + >> +It includes a set of Windows-specific header files and static import li= braries >> +which enable the use of the Windows API. It does not rely on any third= -party C >> +runtime dynamic-link libraries (@dfn{DLL}s). >> + >> +Mingw-w64 is an advancement of the original mingw.org project and provi= des >> +several new APIs such as DirectX and DDK, and 64-bit support.") > > I'd make it a single paragraph. > >> + (license (list >> + license:gpl3+ >> + license:lgpl2.1+)))) > > There should be a comment expliciting why there are two possible > licenses (different files? which ones? dual license? etc.) > > Thank you! > > Maxim I've addressed the above comments, refactored the phases and added the widl tool; you can see the result in commit 44c98c997933c4dc531775f1bb0848b39c7abf37. The version of mingw-w64 is now 8.0.0. Closing, Maxim