From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GJjZFvKZSmAjIwAA0tVLHw (envelope-from ) for ; Thu, 11 Mar 2021 22:30:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CD67EvKZSmCiPAAA1q6Kng (envelope-from ) for ; Thu, 11 Mar 2021 22:30:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 155CE12630 for ; Thu, 11 Mar 2021 23:30:10 +0100 (CET) Received: from localhost ([::1]:38054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKTon-0002cl-93 for larch@yhetil.org; Thu, 11 Mar 2021 17:30:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKTog-0002ca-3N for guix-patches@gnu.org; Thu, 11 Mar 2021 17:30:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKTof-0001Kz-Rj for guix-patches@gnu.org; Thu, 11 Mar 2021 17:30:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKTof-0008Vk-OS for guix-patches@gnu.org; Thu, 11 Mar 2021 17:30:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46182] [PATCH] lint: Add 'check-git-protocol' checker. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Mar 2021 22:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46182 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 46182@debbugs.gnu.org Received: via spool by 46182-submit@debbugs.gnu.org id=B46182.161550179432683 (code B ref 46182); Thu, 11 Mar 2021 22:30:01 +0000 Received: (at 46182) by debbugs.gnu.org; 11 Mar 2021 22:29:54 +0000 Received: from localhost ([127.0.0.1]:55313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKToY-0008V3-EL for submit@debbugs.gnu.org; Thu, 11 Mar 2021 17:29:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKToW-0008Un-91 for 46182@debbugs.gnu.org; Thu, 11 Mar 2021 17:29:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKToR-0001B6-1U; Thu, 11 Mar 2021 17:29:47 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57040 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lKToI-0004Yj-US; Thu, 11 Mar 2021 17:29:41 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 11 Mar 2021 23:29:37 +0100 In-Reply-To: (Leo Famulari's message of "Fri, 29 Jan 2021 20:04:06 -0500") Message-ID: <87zgz9uxwu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615501810; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=N22az6HgI6TUlCGs0IiteZ30RDPEiN81xLYMk3+HIKQ=; b=OIB/n3FG6spvXQ0TqH9ZQXPl/rHHEbVr178q/dwPprBJm2e89UXgi0iTDFbMemrN82K1F5 jLwSpQoZMN8fr+09KRXPoGJ0pQnoPgstVBTTDUVX9Wwza8YbbdkaYUgewf+IhHVgvjm11P 6ldkR459JZUt+GQa65+9KwNPdXoP366bsyrw5JqC66v8/bSh+js/T4jyAjsy9nUR9YZLl8 c3ppnuZdenNLcs8uCsseutx9tysRt/Gt+DzpXvDEj3U8H3SDggvhB+HfRyObkC7sADB+JM 4/wLXF1qlimnRwQ+xTgrClewW6YtullnxhOBrNxPSUglNT24j58vGxBZcCpZeg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615501810; a=rsa-sha256; cv=none; b=kbGC/Aeh1/AythJj0RexfN281AogpJ+Wjb6EKmLQP7VmqYTI4XWDdqQ0VBpjNVTGTjQJvX SpKh3QcJi4xa0xcrsR80fwnTYhbv+ZaCEkeuJqR0U88uewN+bB4jfQ83yO990gN/hOnG9f 5nL/ieNLPXaNfr2pVeEy3q6+J2Lz3H+1jlxGAe2GSPdbP5liqr86NFwctYFD5+/DPVSL1F aJMx/m+Ob/ai1DotIOGmI4EOyCQ2xmfuBZ+3V/14/HUaQwPtGN8sNciI8TfPDYeSU4Q3me aOtvKR6PE0b+du4sEYHfJxKShCJ2GluGDPdZoVFdzreCLu7q5Gf81pWIylkw5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.89 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 155CE12630 X-Spam-Score: -2.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: y/aRSQ5khsAb Hi! Leo Famulari skribis: > We could also make it warn about use of the HTTP protocol (as opposed to > HTTPS). Your thoughts? > > * guix/lint.scm (check-git-protocol): New procedure. > (%local-checkers): Add 'git-protocol' checker. > * doc/guix.texi (Invoking guix lint): Document it. Nice! I think it=E2=80=99s OK to use =E2=80=98eqv?=E2=80=99 here (=E2=80= =98eq?=E2=80=99, even). One nit: it would be nice to add a positive and a negative test in tests/lint.scm. You can run =E2=80=9Cmake check TESTS=3Dtests/lint.scm=E2= =80=9D then. Otherwise LGTM! Thanks, Ludo=E2=80=99.