bug#48214: inetutils-1.9.4 build fails

[Bone Baboon via Bug reports for GNU Guix <bug-guix@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 3589 bytes --]

Bone Baboon via Bug reports for GNU Guix writes:
> I have reported this to the inetutils bug mailing list and asked if the
> inetutils test suite could be modified so that syslogd.sh does not fail
> if IPv6 is disabled.

I received this response on the inetutils mailing list:

> Hi.  Thanks for the report.  Could you investigate if the
> tests/runtime-ipv6.c program return appropriately?  It is supposed to
> check wether the runtime system supports IPv6 or not, and should detect
> this properly on your system (or there is a bug in the self-test code
> elsewhere).
> 
> Looking at the code, I don't think a getaddrinfo-lookup is sufficient,
> the code probably need to attempt to listen to a socket too, in order to
> fully test wether IPv6 is disabled globally or not.

I looked for tests/runtime-ipv6.c in the inetutils's build tree.  I
could not find it.  I looked up the current version of inetutils which
is 2.0.  Guix has 1.9.4 of inetutils packaged.

Based on the response I received on the inetutils mailing list it sounds
like updating the inetutils package to 2.0 may resolve this failing
test.

I tried to build inetutils from the file inetutils-2-0.scm attached.
It's only changes are the version number and hash for inetutils 2.0. It
failed with this error:

```
patching file ifconfig/system.c
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file ifconfig/system.c.rej
patching file ifconfig/system.h
Hunk #1 FAILED at 97.
1 out of 1 hunk FAILED -- saving rejects to file ifconfig/system.h.rej
patching file ifconfig/system/Makefile.am
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file ifconfig/system/Makefile.am.rej
patching file ifconfig/system/generic.c
Hunk #1 FAILED at 22.
Hunk #2 FAILED at 36.
2 out of 2 hunks FAILED -- saving rejects to file ifconfig/system/generic.c.rej
The next patch would create the file ifconfig/system/hurd.c,
which already exists!  Applying it anyway.
patching file ifconfig/system/hurd.c
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ifconfig/system/hurd.c.rej
The next patch would create the file ifconfig/system/hurd.h,
which already exists!  Applying it anyway.
patching file ifconfig/system/hurd.h
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ifconfig/system/hurd.h.rej
patching file ifconfig/system/hurd.c
Hunk #1 succeeded at 186 with fuzz 2 (offset 11 lines).
Hunk #2 FAILED at 194.
1 out of 2 hunks FAILED -- saving rejects to file ifconfig/system/hurd.c.rej
patching file telnet/sys_bsd.c
Hunk #1 succeeded at 64 (offset 1 line).
Hunk #2 succeeded at 159 (offset 1 line).
Hunk #3 succeeded at 262 (offset 1 line).
Hunk #4 succeeded at 759 (offset 1 line).
source is under 'inetutils-2.0'
applying '/gnu/store/pyjlhc8r3xzm169l6symkm2l9wrab6hl-inetutils-hurd.patch'...
Backtrace:
           3 (primitive-load "/gnu/store/401x9biqviwi2xa2sjs9p7c0xsf…")
In ice-9/eval.scm:
    619:8  2 (_ #(#<directory (guile-user) 10d7d0> "inetutils-2.0"))
In srfi/srfi-1.scm:
    634:9  1 (for-each #<procedure apply-patch (a)> ("/gnu/store/py…"))
In guix/build/utils.scm:
    654:6  0 (invoke _ . _)

guix/build/utils.scm:654:6: In procedure invoke:
ERROR:
  1. &invoke-error:
      program: "/gnu/store/qw20chpgkgbcqmzhs60c8hjl1hmblyc8-patch-2.7.6/bin/patch"
      arguments: ("--force" "--no-backup-if-mismatch" "-p1" "--input" "/gnu/store/pyjlhc8r3xzm169l6symkm2l9wrab6hl-inetutils-hurd.patch")
      exit-status: 1
      term-signal: #f
      stop-signal: #f
```


[-- Attachment #2: inetutils-2-0.scm --]
[-- Type: application/octet-stream, Size: 4151 bytes --]

(use-modules
 (gnu packages admin)
 (guix build-system cmake)
 (guix build-system emacs)
 (guix build-system glib-or-gtk)
 (guix build-system gnu)
 (guix build-system go)
 (guix build-system meson)
 (guix build-system perl)
 (guix build-system python)
 (guix build-system ruby)
 (guix build-system trivial)
 (guix download)
 (guix git-download)
 ((guix licenses) #:prefix license:)
 (guix packages)
 (guix utils)
 (gnu packages)
 (gnu packages algebra)
 (gnu packages autogen)
 (gnu packages autotools)
 (gnu packages base)
 (gnu packages bash)
 (gnu packages bison)
 (gnu packages boost)
 (gnu packages c)
 (gnu packages check)
 (gnu packages compression)
 (gnu packages cross-base)
 (gnu packages crypto)
 (gnu packages cryptsetup)
 (gnu packages cyrus-sasl)
 (gnu packages dns)
 (gnu packages elf)
 (gnu packages file)
 (gnu packages flex)
 (gnu packages gawk)
 (gnu packages gettext)
 (gnu packages gl)
 (gnu packages glib)
 (gnu packages gnome)
 (gnu packages gnupg)
 (gnu packages golang)
 (gnu packages groff)
 (gnu packages gtk)
 (gnu packages guile)
 (gnu packages hurd)
 (gnu packages image)
 (gnu packages imagemagick)
 (gnu packages inkscape)
 (gnu packages kerberos)
 (gnu packages libbsd)
 (gnu packages libftdi)
 (gnu packages libunwind)
 (gnu packages libusb)
 (gnu packages linux)
 (gnu packages lua)
 (gnu packages mail)
 (gnu packages man)
 (gnu packages mcrypt)
 (gnu packages mpi)
 (gnu packages ncurses)
 (gnu packages openldap)
 (gnu packages patchutils)
 (gnu packages pciutils)
 (gnu packages pcre)
 (gnu packages perl)
 (gnu packages perl-check)
 (gnu packages pkg-config)
 (gnu packages popt)
 (gnu packages python)
 (gnu packages python-crypto)
 (gnu packages python-web)
 (gnu packages python-xyz)
 (gnu packages qt)
 (gnu packages readline)
 (gnu packages ruby)
 (gnu packages serialization)
 (gnu packages sphinx)
 (gnu packages tcl)
 (gnu packages terminals)
 (gnu packages texinfo)
 (gnu packages tls)
 (gnu packages version-control)
 (gnu packages web)
 (gnu packages xdisorg)
 (gnu packages xml)
 (gnu packages xorg))

(package
 (name "inetutils")
 (version "2.0")
 (source (origin
          (method url-fetch)
          (uri (string-append "mirror://gnu/inetutils/inetutils-"
                              version ".tar.gz"))
          (patches (search-patches "inetutils-hurd.patch"))
          (sha256
           (base32
	    "0j1nb69bhg29cm4xkqqjh2ln1zqcj2lnpm92v638lpwrs11dypxl"))))
;            "05n65k4ixl85dc6rxc51b1b732gnmm8xnqi424dy9f1nz7ppb3xy"))))
 (build-system gnu-build-system)
 (arguments
  `(#:configure-flags '("--localstatedir=/var"
			
                        ;; Make sure 'PATH_PROCNET_DEV' gets defined when
                        ;; cross-compiling (by default it does not.)
                        ,@(if (%current-target-system)
                              '("--with-path-procnet-dev=/proc/net/dev")
                              '())
                        ,@(if (hurd-target?)
                              '("--disable-rcp"
                                "--disable-rexec"
                                "--disable-rexecd"
                                "--disable-rlogin"
                                "--disable-rlogind"
                                "--disable-rsh"
                                "--disable-rshd"
                                "--disable-uucpd"
                                "--disable-whois")
                              '()))
    ;; On some systems, 'libls.sh' may fail with an error such as:
    ;; "Failed to tell switch -a apart from -A".
    #:parallel-tests? #f))
 (inputs `(("ncurses" ,ncurses)
           ("readline" ,readline)))        ;for 'ftp'
 (native-inputs (if (member (%current-system)
                            (package-supported-systems net-tools))
                    `(("netstat" ,net-tools))  ;for tests
                    '()))
 (home-page "https://www.gnu.org/software/inetutils/")
 (synopsis "Basic networking utilities")
 (description
  "Inetutils is a collection of common network programs, such as an ftp
client and server, a telnet client and server, an rsh client and server, and
hostname.")
 (license license:gpl3+))