From: "Ludovic Courtès" <ludo@gnu.org>
To: Brendan Tildesley <mail@brendan.scot>
Cc: 48220-done@debbugs.gnu.org
Subject: bug#48220: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs.
Date: Sat, 08 May 2021 12:23:21 +0200 [thread overview]
Message-ID: <87zgx58qxy.fsf@gnu.org> (raw)
In-Reply-To: <615974577.179836.1620268738791@office.mailbox.org> (Brendan Tildesley's message of "Thu, 6 May 2021 04:38:58 +0200 (CEST)")
Hi!
Brendan Tildesley <mail@brendan.scot> skribis:
[...]
>> However, my understanding is that the xset code is already a fallback:
>
>>
>> --8<---------------cut here---------------start------------->8---
>> # else run another access locking utility, if installed
>> for lock_cmd in \
>> "xlock -mode blank" \
>> "slock"
>> do
>> set -- $lock_cmd
>> if command -v -- $1 >/dev/null 2>&1; then
>> $lock_cmd >/dev/null 2>&1 &
>> # turn off display backlight:
>> xset dpms force off
>> exit
>> fi
>> done
>> --8<---------------cut here---------------end--------------->8---
>>
>> Probably we should ensure the first ‘for’ loop works as expected.
>> Perhaps we need to replace ‘xfce4-screensaver-command’ by its absolute
>> file name there.
>>
>
> Currently xfce4-screensaver is not installed in the xfce package at all by default,
> so it isn't used. I could add it, but for me it was glitchy/flickering and I would keep
> clearing the password as I was entering it so I couldn't log back in. It even does it
> in a VM. I do have a recent amd graphics card with proprietary linux though, my computer
> can't boot otherwise :(.
Hmm OK. We should address this in a separate issue.
> If you run guix environment --ad-hoc xfce4-screensaver
> then
> xfce4-screensaver &; xfce4-screensaver-command --lock
> does it work for you?
I get:
--8<---------------cut here---------------start------------->8---
$ xfce4-screensaver & xfce4-screensaver-command --lock
[1] 19108
** Message: 12:20:44.361: Screensaver is not running! Start xfce4-screensaver first
--8<---------------cut here---------------end--------------->8---
… but I’m not running Xfce. I should prolly try in a VM.
> I'm not sure what is best, should we be maximal and include xfce4-screensaver in the xfce
> package, or be minimal and make people have to install it manually?
I’d lean towards including xfce4-screensaver, since that’s the intended
use of Xfce, but only once it actually works.
> From ed66cf50a3b9294effc8bbae04b0f2564bd55c10 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail@brendan.scot>
> Date: Thu, 6 May 2021 12:34:55 +1000
> Subject: [PATCH] gnu: xfce4-session: Allow xflock4 to use xset.
>
> * gnu/packages/xfce.scm (xfce4-session):
> [inputs]: Add xset.
> [arguments]: Add a phase to use exact store path to xset in xflock4.
[...]
> + (add-after 'unpack 'patch-xflock
> + (lambda _
> + (substitute* "scripts/xflock4"
> + (("xset") (which "xset"))))))))
Applied after changing ‘which’ to refer to the “xset” input so that it
works correctly when cross-compiling.
Closing, and let’s discuss xfce4-screensaver separately!
Thanks,
Ludo’.
prev parent reply other threads:[~2021-05-08 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 9:20 [bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs Brendan Tildesley
2021-05-05 13:23 ` Ludovic Courtès
2021-05-06 2:38 ` Brendan Tildesley
2021-05-06 12:03 ` Efraim Flashner
2021-05-06 12:13 ` Brendan Tildesley
2021-05-08 10:23 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgx58qxy.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48220-done@debbugs.gnu.org \
--cc=mail@brendan.scot \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.