From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id Ga8tFcYtqmCtMAAAgWs5BA (envelope-from ) for ; Sun, 23 May 2021 12:26:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MDFSEMYtqmB0SgAAbx9fmQ (envelope-from ) for ; Sun, 23 May 2021 10:26:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AFE2B9CE for ; Sun, 23 May 2021 12:26:13 +0200 (CEST) Received: from localhost ([::1]:53636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lklJE-0001aX-9A for larch@yhetil.org; Sun, 23 May 2021 06:26:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lklJ5-0001Zb-5i for bug-guix@gnu.org; Sun, 23 May 2021 06:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lklJ3-00007s-VD for bug-guix@gnu.org; Sun, 23 May 2021 06:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lklJ3-0006Vo-SI for bug-guix@gnu.org; Sun, 23 May 2021 06:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47172: Shepherd 0.8.1 tests fail on core-updates Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 23 May 2021 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47172 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 47172@debbugs.gnu.org Received: via spool by 47172-submit@debbugs.gnu.org id=B47172.162176554225004 (code B ref 47172); Sun, 23 May 2021 10:26:01 +0000 Received: (at 47172) by debbugs.gnu.org; 23 May 2021 10:25:42 +0000 Received: from localhost ([127.0.0.1]:40643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lklIk-0006VE-3b for submit@debbugs.gnu.org; Sun, 23 May 2021 06:25:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lklIh-0006Uz-LE for 47172@debbugs.gnu.org; Sun, 23 May 2021 06:25:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57336) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lklIa-0008Op-Jv for 47172@debbugs.gnu.org; Sun, 23 May 2021 06:25:34 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=32830 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lklIW-0000K1-RQ for 47172@debbugs.gnu.org; Sun, 23 May 2021 06:25:32 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <37305bfa08faea95b45a6496623154c2ebab1f11.camel@zaclys.net> Date: Sun, 23 May 2021 12:25:27 +0200 In-Reply-To: <37305bfa08faea95b45a6496623154c2ebab1f11.camel@zaclys.net> ("=?UTF-8?Q?L=C3=A9o?= Le Bouter"'s message of "Mon, 15 Mar 2021 19:51:24 +0100") Message-ID: <87zgwl4ui0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621765573; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=46nBbZAvZdA8j3tiZAtDUOGpck3GF1iUQqVbCM+qTbg=; b=JzC7djGb9Tt8bXhYIoaPulmPiYk/SrzO9IXlFjmIQfEEAlq43zftUfpM9uwCZV4E1agwFW P7N7B/T9ftdnS0+qdOfN8Nf8n1ZIpKa96skPVF5mXUKJEiASuiS7WIs+kCwnfihhSI7OWz cEyNPFN/ld+L3hGx+h45jkBIQBaYuTDGW7rYWBBVTy3ccrGw/qOB5mCn2Z+anzUa2ec3U1 CqdHU2IkDGira6AVnnS7zAL8T/9iAbS6/FJ1U6SVFZEB0yHB7tHT1ofhiZ4ITQ3jC5W2w1 jKWHrnT0J5arsWJKI2wgJKZj4h2h9ZAvuGs68Aw4zmX4Mnb9hiQ+2jztcvdkcQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621765573; a=rsa-sha256; cv=none; b=uS2pYpQGeppkxPIPBTJI2ACRUAlIRKrCKotI0Nfc15iAPf78fDsBuDszmeD/nH6P86830R iIKx5GEpmOdSneb3DJ6/sEdYorGHWhZND1k6DMmIurnWMW8IJK3iNXOxmX5XygqDvmJBNa X/IYbRb/PqhyqVEouDwgJ4y8udcVflrBUqiZH+cdzDQTvoKlhx6wdQfIsV87ahNHncveif jtLAmM/PsWlx+lTB8vNzMMN8RMwiO/cbpoQpPVQSX1TYKAg6EvbPUl95Dt19366McyHSIE vtntakBbVdDOGi4MeNl6YG/VL/B4NoQwJ3K08SeuY9aTgnRajwDPCMtlc8u/wg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 9AFE2B9CE X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: Fr9aBFijKRih Hi there, L=C3=A9o Le Bouter skribis: > Some tests fail: > > FAIL: tests/no-home.sh > FAIL: tests/status-sexp.sh > PASS: tests/misbehaved-client.sh [...] > It seems this is due to guile 3.0.5, GNU Shepherd 0.8.1 does not work > with it, it works with guile 3.0.2 however. This turns out to be due to a=E2=80=A6 miscompilation bug. In (shepherd scripts herd), =E2=80=98run-command=E2=80=99 has this code: (let ((sock (open-connection socket-file)) (action* (if (and (eq? action 'detailed-status) (memq service '(root shepherd))) 'status action))) =E2=80=A6) Problem is that everything works as if (eq? action 'detailed-status) was omitted, such that =E2=80=98herd stop root=E2=80=99 is interpreted as = =E2=80=98herd status root=E2=80=99. Simply wrapping the condition in (pk =E2=80=A6) =E2=80=9Cfixes=E2=80=9D the= problem. The peval output looks good (it contains the 'detailed-status comparison), but the assembly seems to lack the 'detailed-status comparison altogether: --8<---------------cut here---------------start------------->8--- Disassembly of at #x29e0: 0 (instrument-entry 15700) at shepherd/s= cripts/herd.scm:127:2 2 (assert-nargs-ee/locals 1 11) ;; 12 slots (0 args) 3 (static-ref 10 15369) ;; #f at shepherd/s= cripts/herd.scm:128:19 5 (immediate-tag=3D? 10 7 0) ;; heap-object? 7 (je 9) ;; -> L1 8 (static-ref 10 14166) ;; #f 10 (static-ref 9 15372) ;; open-connection 12 (call-scm<-scm-scm 10 10 9 111)=20 14 (static-set! 10 15358) ;; #f L1: 16 (scm-ref/immediate 7 10 1)=20=20=20=20=20=20 17 (scm-ref/immediate 6 11 2)=20=20=20=20=20=20 18 (handle-interrupts) at shepherd/s= cripts/herd.scm:128:18 19 (call 4 2)=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 21 (receive 1 4 12)=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 23 (scm-ref/immediate 9 11 3)=20=20=20=20=20=20 24 (static-ref 8 15360) ;; #f at shepherd/s= cripts/herd.scm:134:6 26 (immediate-tag=3D? 8 7 0) ;; heap-object? 28 (je 9) ;; -> L2 29 (static-ref 8 14145) ;; #f 31 (static-ref 7 15363) ;; write-command 33 (call-scm<-scm-scm 8 8 7 111)=20=20=20 35 (static-set! 8 15349) ;; #f L2: 37 (scm-ref/immediate 8 8 1)=20=20=20=20=20=20=20 38 (static-ref 7 15358) ;; #f at shepherd/s= cripts/herd.scm:134:21 40 (immediate-tag=3D? 7 7 0) ;; heap-object? 42 (je 9) ;; -> L3 43 (static-ref 7 14131) ;; #f 45 (static-ref 6 15361) ;; shepherd-command 47 (call-scm<-scm-scm 7 7 6 111)=20=20=20 49 (static-set! 7 15347) ;; #f L3: 51 (scm-ref/immediate 7 7 1)=20=20=20=20=20=20=20 52 (scm-ref/immediate 6 11 4)=20=20=20=20=20=20 53 (static-ref 5 15363) ;; root 55 (eq? 6 5)=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 56 (je 5) ;; -> L4 57 (static-ref 5 13655) ;; shepherd 59 (eq? 6 5)=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 60 (jne 3) ;; -> L5 L4: 61 (static-ref 9 15365) ;; status at shepherd/s= cripts/herd.scm:131:22 L5: 63 (static-ref 1 15375) ;; #:arguments at shepherd/s= cripts/herd.scm:134:54 65 (scm-ref/immediate 0 11 5)=20=20=20=20=20=20 66 (mov 4 7) at shepherd/s= cripts/herd.scm:134:20 --8<---------------cut here---------------end--------------->8--- (This is compiled with 3.0.7 and the default optimizations, so -O2.) To be continued=E2=80=A6 Ludo=E2=80=99.