all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 47670@debbugs.gnu.org
Subject: [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories
Date: Sun, 06 Jun 2021 15:23:22 +0200	[thread overview]
Message-ID: <87zgw3jfed.fsf_-_@gnu.org> (raw)
In-Reply-To: <87czv3wrnj.fsf@yoctocell.xyz> (Xinglu Chen's message of "Fri, 09 Apr 2021 14:48:00 +0200")

Hi!

Xinglu Chen <public@yoctocell.xyz> skribis:

> On Fri, Apr 09 2021, Xinglu Chen wrote:
>
>> On Fri, Apr 09 2021, Léo Le Bouter via Guix-patches via wrote:
>>
>>> Is that an autogenerated tarball? I am under the impression that usage
>>> of those is banned in GNU Guix, and that there's a lint pass for it.
>>> What do you use these autogenerated tarballs for? Is the 'ls-remote'
>>> command not enough to replace the version and hash?
>>
>> The GitHub updater fetches the autogenerated tarball so that's what I
>> did as well.  I wasn't aware about the fact that we would like to avoid
>> them.
>>
>>> GNU Guix uses shallow clones (AIUI) to save bandwidth, do you need
>>> this to generate the hash? I encourage you use the same shallow clone
>>> mechanism here, so it's more generic and not specific to Sourcehut.
>>
>> Ok, I will use shallow clones to make it more generic.
>
> Umm, the 'upstream-source-compiler' uses 'url-fetch' to fetch the url, I
> guess we would have to make it support Git repositories first.

Yes, that’s a limitation of (guix upstream) right now.
‘%method-updates’ was a first step in the direction of supporting Git
repos.

Now, I agree with Léo that (1) this is not SourceHut-specific, and (2)
it should not download generated archives.

Also, I’d prefer to have the code rely on Guile-Git to list tags rather
than invoking ‘git’, if possible.  Perhaps that code could leave in its
own (guix import git) module or similar, rather than in (guix
gnu-maintenance), which already has little to do with GNU maintenance at
this point.  :-)

Thoughts?

Ludo’.




  reply	other threads:[~2021-06-06 13:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  9:02 [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories Xinglu Chen
2021-04-09  9:05 ` [bug#47670] [PATCH 1/2] upstream: Add predicate for Git URLs Xinglu Chen
2021-04-09  9:05 ` [bug#47670] [PATCH 2/2] gnu-maintenance: Add 'sourcehut-git' updater Xinglu Chen
2021-04-09 10:54 ` [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories Léo Le Bouter via Guix-patches via
2021-04-09 11:58   ` Xinglu Chen
2021-04-09 12:04     ` Léo Le Bouter via Guix-patches via
2021-04-09 12:41       ` Xinglu Chen
2021-04-09 12:48         ` Xinglu Chen
2021-06-06 13:23           ` Ludovic Courtès [this message]
2021-06-11  9:25             ` Xinglu Chen
2021-07-27 10:19               ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgw3jfed.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=47670@debbugs.gnu.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.