From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2KWUAVXgwGBpkQAAgWs5BA (envelope-from ) for ; Wed, 09 Jun 2021 17:37:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OLyROFTgwGCJeQAAbx9fmQ (envelope-from ) for ; Wed, 09 Jun 2021 15:37:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 029FDFCD0 for ; Wed, 9 Jun 2021 17:37:56 +0200 (CEST) Received: from localhost ([::1]:47612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr0HB-0003GS-Hg for larch@yhetil.org; Wed, 09 Jun 2021 11:37:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr0DS-00052u-LC for bug-guix@gnu.org; Wed, 09 Jun 2021 11:34:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lr0DS-0006op-Cz for bug-guix@gnu.org; Wed, 09 Jun 2021 11:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lr0DR-0000Gi-Vf for bug-guix@gnu.org; Wed, 09 Jun 2021 11:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44675: guix lint: support for spellchecker or basic grammar Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 09 Jun 2021 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44675 X-GNU-PR-Package: guix X-GNU-PR-Keywords: easy To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44675-submit@debbugs.gnu.org id=B44675.16232528261003 (code B ref 44675); Wed, 09 Jun 2021 15:34:01 +0000 Received: (at 44675) by debbugs.gnu.org; 9 Jun 2021 15:33:46 +0000 Received: from localhost ([127.0.0.1]:34440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lr0DC-0000G7-7z for submit@debbugs.gnu.org; Wed, 09 Jun 2021 11:33:46 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:60166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lr0D9-0000Fq-L4 for 44675@debbugs.gnu.org; Wed, 09 Jun 2021 11:33:44 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 964431A904; Wed, 9 Jun 2021 08:33:37 -0700 (PDT) From: Vagrant Cascadian In-Reply-To: <87o8dqmozo.fsf@gnu.org> References: <87ima6rrri.fsf@yucca> <87tunznsi7.fsf@yucca> <2f3077c0d040e4b40db19d98195845e124b064d3.camel@telenet.be> <87o8e6nqvv.fsf@yucca> <87o8dqmozo.fsf@gnu.org> Date: Wed, 09 Jun 2021 08:33:33 -0700 Message-ID: <87zgvz129e.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44675@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623253076; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=EsqOJxHWbT4m4QFR/0OEghT2nCH2jWO3Y7OsL79f76I=; b=Tasfqd71WRTfwdGxX+DlpKvWOdrcZFiFJ9NzD1ySLvLXbKOMRuFCVLr7A7y7MCx5ZDW9a4 2tz3G25ek+zk8YQbCoBgo7V4oAvVZG2j6ZOuRRYjBsyOjdNmtkiQ1CeiwyIwR4vcJgQPJo WyIXSdlDDFOlD4FVs8L+1CjWoWcQUYGYelmGH4sbQHJuMTepTEi0kd2ILshwocnVZ+VKfQ brZlDSbG7dLM7r8ZoJUGyKWB0QvWa6/TGnDuLPwx19wHR2z2AbhR3U17HOUbbZnWDUox2R LPExEjeNuqv0CA/7/k4jLrBIY8kW8uNggy34M8ghvAY4qPStyvr/NhkK0XXWCA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623253076; a=rsa-sha256; cv=none; b=RAC4DObjYiVk93kO6iV07W3Iz/xGs+aYvuxh1XfZItYNSuHqyjebwa6zKjLAflEomoZvvR i5TzxW91skNQFvLvl0cedKypkee17I1w7NxX66v6WQnKtMh6Ab2mSbeMNuOo2IbKuInHa1 HUAByJKEPdFGyRWuJaKV/ze3bF6itjYoDJlvI+JhEqdLc820Ltcp6TLTQ0/bkbMVnRsPeY xEk0mWskAQZ42OOx9uk7/PKWN4aMO4oAVl55BhfKQJtFH2pBCu2EkcIvYWUuEIQttYl00X hv6jX4MFK1ViYGhEEa0txNulo1b5qnVFVeEwn82UEvDghRtSS5tvfBPFEoGgGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -4.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 029FDFCD0 X-Spam-Score: -4.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: nTLwxqSNM5uW --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-05-04, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: > >> From 4e724fbe9815e1c27967b835f08d2259164538ba Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian >> Date: Wed, 21 Apr 2021 09:26:45 -0700 >> Subject: [PATCH] lint: Add description check for pluralized "This packag= e" >> >> Partial fix for: https://issues.guix.gnu.org/44675 >> >> * guix/lint.scm (check-pluralized-this-package): Add check for >> occurances of "This packages" in package descriptions. >> * tests/lint.scm: Add test. > > I had missed this patch, nice! > >> + (define (check-pluralized-this-package description) >> + "Check that DESCRIPTION does not contain 'This packages'" >> + (if (string-match "This packages" description) >> + (list >> + (make-warning package >> + (G_ "description contains 'This packages' but should just be '= This package'"))) >> + '())) > > How about making this =E2=80=98check-spelling=E2=80=99 and generalizing a= bit so that it > iterates over a bunch of regexps or strings? > > Like: > > (if (any (cut string-contains description <>) patterns) > =E2=80=A6) > > where =E2=80=98patterns=E2=80=99 is a list of strings. Love the idea, but would need some help in implementing! There have been at least three newly added "This packages" since I submitted this patch, so wondering if we can at least get the simple case merged before getting too caught up in all the potential improvements? > (Note that =E2=80=98string-match=E2=80=99 invokes libc=E2=80=99s regcomp = + regexec, so it=E2=80=99s more > heavyweight than needed here.) I can probably manage that! (I'll dig up where the simpler suggestion was) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYMDfTQAKCRDcUY/If5cW qgzgAP9D/QK00msHp9nAnF49CJThYxuajJrLHjts0/9KLXy9JQEAw4CVPdEbgH67 AGhsq8QOmGHm6cdfa21MIKqdP/zv7Q8= =iO+2 -----END PGP SIGNATURE----- --=-=-=--